User tests: Successful: Unsuccessful:
Pull Request for Issue #15730
This PR contains two parts.
Itemid
to a link that does not have any Itemid
(If active is not available)Itemid
(from previous page) to a link that does not have any Itemid
.Test issue #15730.
Every links work.
You may see more links like index/component/...
.
It would be good to create for them menu items to get better SEO.
Before this patch mentioned links use various of menu items to point to the same article/category, etc.
Example: When you are on article view with menu item and the category and parent categories (of this article) does not own menu item then link to category will be (after PR) index.php/component/content/category/[id]-[alias]
instead of (before PR) /alias-to-article/[id]-[category]
See above
Note: Itemid
in URL query won't be inherited from default/previous page as was before.
Status | New | ⇒ | Pending |
Category | ⇒ | Libraries Unit Tests |
I am not very familiar with multilingual websites. There is a lot of configurations. I will check that.
Can you add more details, examples?
It is very simple:
Create a multingual site with 2 languages (en-GB + another) with default sample as explained when you install Joomla as multilang.
Set the default site language to en-GB.
Set the superuser default site language to your other language.
In the languagefilter plugin make sure Automatic Language Change
is set to yes.
Add a Login module in frontend (you can set it to ALL languages s it does not matter in this case).
Navigate to en-GB Home page.
Login.
Your superUser will be redirected to the other language (his default site language) Home page.
If some menu items are associated (therefore exist in both languages) and you log while the en-GB is displayed, then login may redirect you to the associated menu item in the user preferred site language.
@csthomas see my install video:
https://fairplayhost.com/joomla_bug2.webm
This will show how you can test your solution on multi language site...
What important: install with BROCHURE sample data because with BLOG sample data will evrything fine :D
What important: install with BROCHURE sample data because with BLOG sample data will evrything fine :D
NO. use the default multilang sample. All will be ready.
Labels |
Added:
?
?
|
Category | Libraries Unit Tests | ⇒ | Libraries Modules Front End Unit Tests |
Category | Libraries Unit Tests Modules Front End | ⇒ | Libraries Modules Front End Plugins Unit Tests |
Now it should be better.
@infograf768
Should I move modules/mod_login/tmpl/default.php
and plugins/system/languagefilter/languagefilter.php
to another PR?
@csthomas THX this working 90% of cases
@infograf768 I tested for you :D
My setup:
Working good, BUT admin/user can't login via offline page if both HOME menu availabale registered user. If en-GB is public i can login, and redirected to Hungarian language, IF en-GB for registered users and hu-HU is public i can't login too (from /en/ url route)
Normal way allways worked!!!!
I tested on github version... and joomla 3.8.3 too (on 3.8.3 fresh install and my live lcal copy too)
Another bug on github version: menu language doesn't changed... :( I tested on fresh install and with @csthomas fix.. both faild to change manu language however HOME menu will avail to public!!!
Category | Libraries Unit Tests Modules Front End Plugins | ⇒ | Libraries Modules Front End Plugins Templates (site) Unit Tests |
Sorry folks. Away until 25th. Will test then.
@senderdc Please post your test result here: https://issues.joomla.org/tracker/joomla-cms/19099
@senderdc how to mark your Test as successfully:
I have tested this item
Thanks! This was helpful, I'm newbie :)
I have tested this item
Looks good!
Status | Pending | ⇒ | Ready to Commit |
Ready to Commit after two successful tests.
Status | Ready to Commit | ⇒ | Fixed in Code Base |
Closed_Date | 0000-00-00 00:00:00 | ⇒ | 2018-01-03 00:14:26 |
Closed_By | ⇒ | mbabker | |
Labels |
Added:
?
|
This is not B/C on multingual sites.
A user which default site language is set differently than the Home page set to registered will be logged into that page and not into his defined site default language.
Tested also when the home page is NOT set to registered and it is the same issue.
Therefore this patch totally breaks the Automatic Language Change as coded in the languagefilter plugin.