? ? ? Pending

User tests: Successful: Unsuccessful:

avatar csthomas
csthomas
18 Dec 2017

Pull Request for Issue #15730

Summary of Changes

This PR contains two parts.

  1. Do not add default/home Itemid to a link that does not have any Itemid (If active is not available)
  2. Do not add active Itemid (from previous page) to a link that does not have any Itemid.

Testing Instructions

Test issue #15730.

Expected result

Every links work.

You may see more links like index/component/....
It would be good to create for them menu items to get better SEO.
Before this patch mentioned links use various of menu items to point to the same article/category, etc.

Example: When you are on article view with menu item and the category and parent categories (of this article) does not own menu item then link to category will be (after PR) index.php/component/content/category/[id]-[alias] instead of (before PR) /alias-to-article/[id]-[category]

Actual result

See above

Documentation Changes Required

Note: Itemid in URL query won't be inherited from default/previous page as was before.

Votes

# of Users Experiencing Issue
1/1
Average Importance Score
5.00

avatar csthomas csthomas - open - 18 Dec 2017
avatar csthomas csthomas - change - 18 Dec 2017
Status New Pending
avatar joomla-cms-bot joomla-cms-bot - change - 18 Dec 2017
Category Libraries Unit Tests
avatar infograf768
infograf768 - comment - 18 Dec 2017

This is not B/C on multingual sites.
A user which default site language is set differently than the Home page set to registered will be logged into that page and not into his defined site default language.
Tested also when the home page is NOT set to registered and it is the same issue.
Therefore this patch totally breaks the Automatic Language Change as coded in the languagefilter plugin.

avatar csthomas
csthomas - comment - 18 Dec 2017

I am not very familiar with multilingual websites. There is a lot of configurations. I will check that.

Can you add more details, examples?

avatar infograf768
infograf768 - comment - 18 Dec 2017

It is very simple:
Create a multingual site with 2 languages (en-GB + another) with default sample as explained when you install Joomla as multilang.
Set the default site language to en-GB.
Set the superuser default site language to your other language.
In the languagefilter plugin make sure Automatic Language Change is set to yes.
Add a Login module in frontend (you can set it to ALL languages s it does not matter in this case).

Navigate to en-GB Home page.
Login.
Your superUser will be redirected to the other language (his default site language) Home page.

If some menu items are associated (therefore exist in both languages) and you log while the en-GB is displayed, then login may redirect you to the associated menu item in the user preferred site language.

avatar senderdc
senderdc - comment - 18 Dec 2017

@csthomas see my install video:
https://fairplayhost.com/joomla_bug2.webm

This will show how you can test your solution on multi language site...
What important: install with BROCHURE sample data because with BLOG sample data will evrything fine :D

avatar infograf768
infograf768 - comment - 18 Dec 2017

What important: install with BROCHURE sample data because with BLOG sample data will evrything fine :D

NO. use the default multilang sample. All will be ready.

avatar csthomas csthomas - change - 20 Dec 2017
Labels Added: ? ?
avatar joomla-cms-bot joomla-cms-bot - change - 20 Dec 2017
Category Libraries Unit Tests Libraries Modules Front End Unit Tests
avatar joomla-cms-bot joomla-cms-bot - change - 20 Dec 2017
Category Libraries Unit Tests Modules Front End Libraries Modules Front End Plugins Unit Tests
avatar csthomas
csthomas - comment - 20 Dec 2017

Now it should be better.

avatar csthomas
csthomas - comment - 21 Dec 2017

@infograf768
Should I move modules/mod_login/tmpl/default.php and plugins/system/languagefilter/languagefilter.php to another PR?

avatar infograf768
infograf768 - comment - 21 Dec 2017

@csthomas
I don't think so. The issue should be solved in one PR only.
Will test later.

avatar senderdc
senderdc - comment - 21 Dec 2017

@csthomas THX this working 90% of cases

@infograf768 I tested for you :D

My setup:

  • site default lang: en-GB
  • admin user lang: hu-HU,
  • sample data BROCHURE
  • both HOME menu registered only)

Working good, BUT admin/user can't login via offline page if both HOME menu availabale registered user. If en-GB is public i can login, and redirected to Hungarian language, IF en-GB for registered users and hu-HU is public i can't login too (from /en/ url route)

Normal way allways worked!!!!

I tested on github version... and joomla 3.8.3 too (on 3.8.3 fresh install and my live lcal copy too)

Another bug on github version: menu language doesn't changed... :( I tested on fresh install and with @csthomas fix.. both faild to change manu language however HOME menu will avail to public!!!

avatar joomla-cms-bot joomla-cms-bot - change - 21 Dec 2017
Category Libraries Unit Tests Modules Front End Plugins Libraries Modules Front End Plugins Templates (site) Unit Tests
avatar csthomas
csthomas - comment - 21 Dec 2017

@senderdc I fixed the problem with login from offline page.

Another bug on github version: menu language doesn't changed...

You can create an issue for that.
It's not enough information for me.

avatar infograf768
infograf768 - comment - 21 Dec 2017

Sorry folks. Away until 25th. Will test then.

avatar senderdc
senderdc - comment - 21 Dec 2017

@csthomas THX working good

PS i did myself too but forgotten to overwrite protostar offline.php :D and thats why don't work for me the sam fix :D

avatar Quy
Quy - comment - 21 Dec 2017
avatar franz-wohlkoenig
franz-wohlkoenig - comment - 21 Dec 2017

@senderdc how to mark your Test as successfully:

  • open Issue Tracker
  • Login with your github-Account
  • Click on blue "Test this"-Button above Authors-Picture
  • mark your Test as successfully
  • hit "submit test result"
avatar senderdc senderdc - test_item - 21 Dec 2017 - Tested successfully
avatar senderdc
senderdc - comment - 21 Dec 2017

I have tested this item successfully on 4f3a4e5


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/19099.

avatar senderdc
senderdc - comment - 21 Dec 2017

@franz-wohlkoenig

Thanks! This was helpful, I'm newbie :)

avatar infograf768 infograf768 - test_item - 26 Dec 2017 - Tested successfully
avatar infograf768
infograf768 - comment - 26 Dec 2017

I have tested this item successfully on 4f3a4e5


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/19099.

avatar infograf768
infograf768 - comment - 26 Dec 2017

Looks good!

avatar franz-wohlkoenig franz-wohlkoenig - change - 26 Dec 2017
Status Pending Ready to Commit
avatar franz-wohlkoenig
franz-wohlkoenig - comment - 26 Dec 2017

Ready to Commit after two successful tests.

avatar mbabker mbabker - change - 3 Jan 2018
Status Ready to Commit Fixed in Code Base
Closed_Date 0000-00-00 00:00:00 2018-01-03 00:14:26
Closed_By mbabker
Labels Added: ?
avatar mbabker mbabker - close - 3 Jan 2018
avatar mbabker mbabker - merge - 3 Jan 2018

Add a Comment

Login with GitHub to post a comment