? ? Failure

User tests: Successful: Unsuccessful:

avatar phalouvas
phalouvas
8 Dec 2017

Pull Request for Issue #19016 .

Summary of Changes

BannerTable.txt

Testing Instructions

Open an existing banner and save it.

Expected result

Save the banner

Actual result

Without the patch, fails to save.

Documentation Changes Required

avatar phalouvas phalouvas - open - 8 Dec 2017
avatar phalouvas phalouvas - change - 8 Dec 2017
Status New Pending
avatar joomla-cms-bot joomla-cms-bot - change - 8 Dec 2017
Category Unit Tests Repository JavaScript Administration com_admin
avatar franz-wohlkoenig
franz-wohlkoenig - comment - 8 Dec 2017

This PR is created Today but has Comments from October?

avatar rdeutz
rdeutz - comment - 8 Dec 2017

you are trying to merge the 4.0 branch into staging, you shouldn't try this :-)

avatar rdeutz rdeutz - change - 8 Dec 2017
Status Pending Closed
Closed_Date 0000-00-00 00:00:00 2017-12-08 08:14:59
Closed_By rdeutz
Labels Added: ? ?
avatar rdeutz rdeutz - close - 8 Dec 2017
avatar phalouvas
phalouvas - comment - 8 Dec 2017

sorry for this. Still the issue #19016 is valid. I attached a patch for it.

avatar rdeutz
rdeutz - comment - 8 Dec 2017
  • you should check out the 4.0-dev branch
  • make changes
  • submit a PR based on the 4.0-dev branch

If you find yourself in a situation with 8000 changed files in a PR something is wrong

Add a Comment

Login with GitHub to post a comment