? Pending

User tests: Successful: Unsuccessful:

avatar C-Lodder
C-Lodder
1 Dec 2017

Summary of Changes

This is for the administrator menu module

  • Use namespaced classes everywhere
  • Remove jQuery call
  • Add minified file
avatar C-Lodder C-Lodder - open - 1 Dec 2017
avatar C-Lodder C-Lodder - change - 1 Dec 2017
Status New Pending
avatar joomla-cms-bot joomla-cms-bot - change - 1 Dec 2017
Category Modules Administration JavaScript
avatar C-Lodder
C-Lodder - comment - 1 Dec 2017

@infograf768 - Does this directory need to be here?

administrator\modules\mod_multilangstatus\language\en-GB

If not I'll remove it in this PR

avatar dgt41
dgt41 - comment - 1 Dec 2017

Add the non minified js file

avatar C-Lodder
C-Lodder - comment - 1 Dec 2017

@dgt41 - It already exists. The minified file was just missing

avatar brianteeman brianteeman - test_item - 1 Dec 2017 - Tested successfully
avatar brianteeman
brianteeman - comment - 1 Dec 2017

I have tested this item successfully on 714f20f


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/18947.

avatar infograf768
infograf768 - comment - 2 Dec 2017

@C-Lodder

If not I'll remove it in this PR

I guess you can. In 2.5 we added this to demonstrate the possibility of settings a language folder in an extension root.
If you do, then also modify the xml which contains <folder>language</folder>

Note: we should keep these extension language folders imho for templates as they could be deleted and re-installing them would not reinstall the language strings.

avatar infograf768
infograf768 - comment - 2 Dec 2017

Test OK here btw. At last it works ?

avatar franz-wohlkoenig franz-wohlkoenig - alter_testresult - 2 Dec 2017 - infograf768: Tested successfully
avatar franz-wohlkoenig franz-wohlkoenig - change - 2 Dec 2017
Status Pending Ready to Commit
avatar franz-wohlkoenig
franz-wohlkoenig - comment - 2 Dec 2017

Ready to Commit after two successful tests.

avatar wilsonge wilsonge - change - 2 Dec 2017
Status Ready to Commit Fixed in Code Base
Closed_Date 0000-00-00 00:00:00 2017-12-02 16:55:58
Closed_By wilsonge
Labels Added: ?
avatar wilsonge wilsonge - close - 2 Dec 2017
avatar wilsonge wilsonge - merge - 2 Dec 2017
avatar wilsonge
wilsonge - comment - 2 Dec 2017

Thanks!

Add a Comment

Login with GitHub to post a comment