User tests: Successful: Unsuccessful:
Pull Request for Issue # .
Changes for the com_wrapper and mod_wrapper to use custom elements.
This fixes:
None. The new code reflects the old behaviour!
Status | New | ⇒ | Pending |
Category | ⇒ | JavaScript Repository Front End com_wrapper Modules |
Labels |
Added:
?
|
and when you look at where we use them in the admin ui you will see how abused they are and how they are not used correctly.
@brianteeman shall we do the a11y part in another PR?
i dont see why. this is a total replacement of the current iframe code so why leave it til after this one has been merged. its just duplicating work for you and for testers.
Ok, so title will be the menu title for the component and the module title for the modules?
For _wrapper then yes that will should be ok but note it won't be in other places in the core that we have iframe it won't be
@dgt41 can this PR be tested, can you give Test Instructions?
Status | Pending | ⇒ | Information Required |
Reminder for @dgt41
@franz-wohlkoenig done
Status | Information Required | ⇒ | Pending |
I have tested this item
@Anu1601CS done
I can't test. :(
let this PR to merge #19836
@franz-wohlkoenig , @astridx can you test again if you are not getting this issue .
@Anu1601CS does that happen when you save a module?
Can you test if my pr is working?
I have got problems with this brach.
After applying I see an error message in both wrapper modules and I can see only the second iframe.
Error Message
Notice: Undefined variable: title in /var/www/html/JOOMLA/joomla4/joomla-cms/modules/mod_wrapper/tmpl/default.php on line 24 Call Stack #TimeMemoryFunctionLocation 10.0001363648{main}( ).../index.php:0 20.0001364128require_once( '/var/www/html/JOOMLA/joomla4/joomla-cms/includes/app.php' ).../index.php:36 30.01511397824Joomla\CMS\Application\SiteApplication->execute( ).../app.php:38 40.09532786032Joomla\CMS\Application\SiteApplication->render( ).../CMSApplication.php:351 50.09542786056Joomla\CMS\Application\SiteApplication->render( ).../SiteApplication.php:754 60.10042820232Joomla\CMS\Document\HtmlDocument->render( ).../CMSApplication.php:1083 70.10042820232Joomla\CMS\Document\HtmlDocument->_renderTemplate( ).../HtmlDocument.php:555 80.10612886528Joomla\CMS\Document\HtmlDocument->getBuffer( ).../HtmlDocument.php:780 90.10612886608Joomla\CMS\Document\Renderer\Html\ModulesRenderer->render( ).../HtmlDocument.php:489 100.10792933800Joomla\CMS\Document\Renderer\Html\ModuleRenderer->render( ).../ModulesRenderer.php:47 110.10802936432Joomla\CMS\Helper\ModuleHelper::renderModule( ).../ModuleRenderer.php:98 120.10812957080include( '/var/www/html/JOOMLA/joomla4/joomla-cms/modules/mod_wrapper/mod_wrapper.php' ).../ModuleHelper.php:204 130.10822958312require( '/var/www/html/JOOMLA/joomla4/joomla-cms/modules/mod_wrapper/tmpl/default.php' ).../mod_wrapper.php:26 " iframe-class="wrapper">
@C-Lodder Why do people need to complicate things, and don't want to make it simpler?
@dgrammatiko There will not be any merging, because this uses old HTML4 standard, and it will be extremley dificult for me to modify this heap of files to new HTML5 standard.
BTW, I created a similar PR, but for Joomla 3.8 and I can inform you that my solution works on my 2 web-sites. #19965
@BaleshSrle can you explain me what is complicate here? I'm just using the W3C standards Custom Elements, is that complicated? If so you should rethink your involvement
with the web.
Anyways I've asked people with merge right to first merge your PR and then I'll patch things here
@BaleshSrle - I have no idea what you're on about and why you're asking me
@C-Lodder I don't know, maybe because I can see widsom on you.
@dgrammatiko I looked at the heap of files that you created and I can honestly say that Joomla 4 will be one heavy CMS to upload (unzipped maybe over 25 to 30 MB). And yes, you are using W3C's old HTML4 standard, but I'm using W3C's new HTML5 standard.
Can you fix the conflicts on this one please?
Can you remove the commented out code please
Status | Pending | ⇒ | Closed |
Closed_Date | 0000-00-00 00:00:00 | ⇒ | 2018-08-29 10:23:01 |
Closed_By | ⇒ | dgrammatiko |
Sometimes wish iframes would just become obselete