Feeling Lucky
?
?
[#18878] - Cli App Injection
- Fixed in Code Base
- 27 Nov 2017
- Medium
- Build: 4.0-dev
- # 18878
- Diff
- wilsonge:cli-app-injection
User tests: Successful: Unsuccessful:
Summary of Changes
Fixes 2 of the 3 remaining unit tests by allowing JInputCli objects to be injected into the \Joomla\CMS\Application\CliApplication class
Testing
Check unit tests pass + code review
| Status | New | ⇒ | Pending |
joomla-cms-bot
- | Category | ⇒ | Libraries Unit Tests |
wilsonge
- comment
- 27 Nov 2017
I thought it was better safe than sorry to stop stupid. But in theory I guess it should be fine
mbabker
- comment
- 27 Nov 2017
Let's be honest here. We're dealing with fully custom CLI architecture at this point. I think there's less to be defensive about here.
| Labels |
Added:
?
?
|
||
wilsonge
- comment
- 27 Nov 2017
okies :) removed
| Status | Pending | ⇒ | Fixed in Code Base |
| Closed_Date | 0000-00-00 00:00:00 | ⇒ | 2017-11-27 00:26:09 |
| Closed_By | ⇒ | mbabker |
Well, it can work, but you wouldn't be able to parse the CLI arguments out without doing
$this->input->cli->get(). For me it works, I just wonder if the extra check is really needed.