[#18877] - [4.0] Upgrade PHP CS Fixer to v2
- Fixed in Code Base
- 20 Aug 2018
- Medium
- Build: 4.0-dev
- # 18877
- Diff
- keradus:4-php-cs-fixer2
User tests: Successful: Unsuccessful:
I only moved configuration to follow v2, not v1.
I did not reapply rules yet, I have few questions first
| Status | New | ⇒ | Pending |
joomla-cms-bot
- | Category | ⇒ | Repository External Library Composer Change |
| Labels |
Added:
?
?
|
||
anyone ?
anyone? few more weeks and it will be half year old :(
| Title |
|
||||||
I did not changed any styling here, as stated in initial post.
I only upgraded version of tool, fix configuration to match new version keeping rules the same (eg handle rename of rule, but not adding/removing rules)
Drone fails with the same error I do have when I do test your pr:
The requested package symfony/options-resolver v3.4.14 is satisfiable by symfony/options-resolver[v3.4.14] but these conflict with your requirements or minimum-stability.
When I do composer update friendsofphp/php-cs-fixer then it regenerates the lock file and it starts installig the dependencies. So you probably should run that command again and then commit your lock file. So we can merge here.
yeah, almost one year old lockfile may not be up to date anymore...
regenerated
Now everything works as expected. Thanks a lot!
| Status | Pending | ⇒ | Fixed in Code Base |
| Closed_Date | 0000-00-00 00:00:00 | ⇒ | 2018-08-20 15:58:52 |
| Closed_By | ⇒ | laoneo |
basically, I have moved the config from v1 to v2 and drop array_syntax rule.
Let me know do you want me to do sth more in this PR.