Feeling Lucky
?
?
[#18821] - [4.0] Fix mail test
- Closed
- 22 Jul 2018
- Medium
- Build: 4.0-dev
- # 18821
- Diff
- asika32764:fix-mail-tester
User tests: Successful: Unsuccessful:
Pull Request for Issue #18779 .
Summary of Changes
Fixed the mail test in configuration for #18779
The change of this PR includes:
- Fixed CSRF for Ajax
- Fixed Ajax error handler
- Fixed JS get value from new switch button. (Since it has 2 inputs with same name, we must add
:checkedselector) - Use
JsonInputto get test mail information. - Use Namespaces.
- Add missing translations.
Testing Instructions
Click Send Test Mail, should display correct message (Success or Error, not CSRF invalid message).
| Status | New | ⇒ | Pending |
joomla-cms-bot
- | Category | ⇒ | Administration com_config Language & Strings Libraries JavaScript |
| Title |
|
||||||
| Labels |
Added:
?
?
|
||
asika32764
- comment
- 23 Nov 2017
Done
brianteeman
- comment
- 22 Jul 2018
It has been a very long time since this PR was submitted and as there has been no response to the comments and no tests I am closing this as an abandoned PR. It can always be reopened if updated
| Status | Pending | ⇒ | Closed |
| Closed_Date | 0000-00-00 00:00:00 | ⇒ | 2018-07-22 09:09:58 |
| Closed_By | ⇒ | brianteeman |
Please also commit the minified JS files too. If you don't feel comfortable with Grunt, you can use: https://skalman.github.io/UglifyJS-online/