Joomla! Issue Tracker - CMS

Download
Launch
Feeling Lucky

[#18810] - [4.0] searchtools should also clear search field

? Pending

User tests: Successful: Unsuccessful:

avatar mvanvu
mvanvu
23 Nov 2017

Before PR

Click on the clear button to reset all input value but the input search is not cleared

After PR

The search field should be cleared

avatar mvanvu mvanvu - open - 23 Nov 2017
avatar mvanvu mvanvu - change - 23 Nov 2017
Status New ⇒ Pending
avatar joomla-cms-bot joomla-cms-bot - change - 23 Nov 2017
Category ⇒ JavaScript
avatar C-Lodder
C-Lodder - comment - 23 Nov 2017

You've also need to commit the .min.js file too

avatar mvanvu mvanvu - change - 23 Nov 2017
Labels Added: ?
avatar franz-wohlkoenig
franz-wohlkoenig - comment - 23 Nov 2017

@mvanvu is this PR for an allready open Issue?

avatar mvanvu
mvanvu - comment - 23 Nov 2017

@franz-wohlkoenig No, it isn't

avatar franz-wohlkoenig franz-wohlkoenig - test_item - 23 Nov 2017 - Tested unsuccessfully
avatar franz-wohlkoenig
franz-wohlkoenig - comment - 23 Nov 2017

I have tested this item ? unsuccessfully on e37031e

With and -out PR Searchfield isn't cleared after Click on "Clear"-Button. No Javascript-Errors in Web Developer-Console.

System information

4.0.0-dev
Multilanguage Site (4 Lang.) & Sample Data
macOS Sierra, 10.12.6
Firefox 57 (64-bit)

MAMP 4.2

  • PHP 7.0.22
  • MySQLi 5.6.35
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/18810.
avatar brianteeman
brianteeman - comment - 23 Nov 2017

@franz-wohlkoenig did you have debug enabled? if not then joomla will use the existing minified file which is not in the pr as mentioned above by @C-Lodder

Also this looks to be a PR to fix #17195

avatar brianteeman brianteeman - test_item - 23 Nov 2017 - Tested successfully
avatar brianteeman
brianteeman - comment - 23 Nov 2017

I have tested this item ✅ successfully on e37031e

Tested in debug mode so that the non minified js could be used and the test is successful

please add the minified version to this PR

This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/18810.
avatar franz-wohlkoenig franz-wohlkoenig - test_item - 23 Nov 2017 - Tested successfully
avatar franz-wohlkoenig
franz-wohlkoenig - comment - 23 Nov 2017

I have tested this item ✅ successfully on e37031e

@brianteeman thanks for Hint for "debug enabled".

This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/18810.
avatar franz-wohlkoenig franz-wohlkoenig - change - 23 Nov 2017
Status Pending ⇒ Ready to Commit
avatar franz-wohlkoenig
franz-wohlkoenig - comment - 23 Nov 2017

Ready to Commit after two successful tests.

avatar C-Lodder
C-Lodder - comment - 23 Nov 2017

@franz-wohlkoenig - The minified JS file is still missing. Please remove RTC till it has been committed

avatar franz-wohlkoenig franz-wohlkoenig - change - 23 Nov 2017
Status Ready to Commit ⇒ Pending
avatar franz-wohlkoenig
franz-wohlkoenig - comment - 23 Nov 2017

Status set on "Pending".

This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/18810.

avatar C-Lodder
C-Lodder - comment - 23 Nov 2017

@mvanvu - Please minify the file properly using grunt or https://skalman.github.io/UglifyJS-online/

avatar wilsonge wilsonge - change - 26 Nov 2017
Status Pending ⇒ Fixed in Code Base
Closed_Date 0000-00-00 00:00:00 ⇒ 2017-11-26 23:19:45
Closed_By ⇒ wilsonge
avatar wilsonge wilsonge - close - 26 Nov 2017
avatar wilsonge wilsonge - merge - 26 Nov 2017
avatar wilsonge
wilsonge - comment - 26 Nov 2017

Thanks :)

Add a Comment

Login with GitHub to post a comment