Joomla! Issue Tracker - CMS

Download
Launch
Feeling Lucky

[#18796] - [4.0] Correct wrong tag "base" to "head" in templates/system/incompatible.html

? Pending

User tests: Successful: Unsuccessful:

avatar richard67
richard67
22 Nov 2017

Pull Request for no issue.

Summary of Changes

In templates/system/incompatible.html, "base" tag is used instead of "head".

This error comes from PR #18777.

Testing Instructions

Code review.

Expected result

Correct HTML.

Actual result

Incorrect HTML.

Documentation Changes Required

None.

avatar richard67 richard67 - open - 22 Nov 2017
avatar richard67 richard67 - change - 22 Nov 2017
Status New ⇒ Pending
avatar joomla-cms-bot joomla-cms-bot - change - 22 Nov 2017
Category ⇒ Front End Templates (site)
avatar richard67
richard67 - comment - 22 Nov 2017

@dgt41 @wilsonge Please check. Code style errors reported by Drone and Travis are not relate to this PR here.

avatar mbabker mbabker - change - 22 Nov 2017
Status Pending ⇒ Fixed in Code Base
Closed_Date 0000-00-00 00:00:00 ⇒ 2017-11-22 18:46:12
Closed_By ⇒ mbabker
Labels Added: ?
avatar mbabker mbabker - close - 22 Nov 2017
avatar mbabker mbabker - merge - 22 Nov 2017
avatar richard67
richard67 - comment - 22 Nov 2017

@mbabker Wow, that was fast. Thanks.

avatar dgt41
dgt41 - comment - 22 Nov 2017

@richard67 thanks, I'll blame emmet here

avatar richard67
richard67 - comment - 22 Nov 2017

@dgt41 Was obvious when looking at the diff of the file ... what people always should do with their PRs ... and again do the guy who merges it ... so I would not only blame emmet here but 2 more people.

avatar dgt41
dgt41 - comment - 22 Nov 2017

?

Add a Comment

Login with GitHub to post a comment