J4 Issue ?
avatar C-Lodder
C-Lodder
22 Nov 2017

If I'm not mistaken, jQuery UI was only ever used in Joomla to sort the rows in list views. Seeing as we have moved to Dragula, we can remove the jQuery UI dependency.

  • Deprecate JHtml ui function in 3.x
  • Remove JHtml ui function in 4.0
  • Convert subform fields to custom element
  • TinyMCE (tinymce-builder.js)
avatar C-Lodder C-Lodder - open - 22 Nov 2017
avatar joomla-cms-bot joomla-cms-bot - change - 22 Nov 2017
Labels Added: ?
avatar joomla-cms-bot joomla-cms-bot - labeled - 22 Nov 2017
avatar C-Lodder C-Lodder - change - 22 Nov 2017
The description was changed
avatar C-Lodder C-Lodder - edited - 22 Nov 2017
avatar franz-wohlkoenig franz-wohlkoenig - change - 22 Nov 2017
Category JavaScript
avatar dgt41
dgt41 - comment - 22 Nov 2017

Calling @wilsonge and @mbabker here for a decision

avatar wilsonge
wilsonge - comment - 22 Nov 2017

Their repo seems pretty much abandoned. Nothing much done in the last 3-6 months.

Do we know what the migration from a code perspective form jquery ui to Dragula is like? I have no problem killing jquery ui. Just want an easy’ish transition for people doing drag + drop

avatar dgt41
dgt41 - comment - 22 Nov 2017

Comparing the effort for the sortable->draggable I'll say it's a couple days work: 17b8f67

avatar franz-wohlkoenig franz-wohlkoenig - change - 23 Nov 2017
Status New Discussion
avatar C-Lodder C-Lodder - change - 23 Nov 2017
The description was changed
avatar C-Lodder C-Lodder - edited - 23 Nov 2017
avatar C-Lodder C-Lodder - change - 23 Nov 2017
The description was changed
avatar C-Lodder C-Lodder - edited - 23 Nov 2017
avatar Fedik
Fedik - comment - 25 Nov 2017

hm, I tried to add Dragula.js to subform.js but cannot get "sorting" to work,
it just ignores it

avatar dgt41
dgt41 - comment - 25 Nov 2017

@Fedik what is the branch you’re working?

avatar Fedik
Fedik - comment - 25 Nov 2017

this one https://github.com/Fedik/joomla-cms/tree/subform-dragula
it start "drag", but "drop" does nothing

avatar Fedik
Fedik - comment - 26 Dec 2017

this seems works fine https://github.com/Shopify/draggable/tree/master/src/Sortable
but it still in Beta, and do not have "pre compiled" version, or I have missed something

avatar dgt41
dgt41 - comment - 26 Dec 2017

@Fedik but do we need a precompiled version? I mean if we implement subform as a custom element then we can import the parts we need from the draggable. Still we need to figure out how to pack all this in a single file and transpile it to es5 but I think it wouldn't be so hard at the end

avatar Fedik
Fedik - comment - 26 Dec 2017

but do we need a precompiled version?

I would like to keep it separated "here is sortable.js and there is subform.js", so sortable.js can be reused,
but we also can merge to single file, if need.

but it still in beta state ?
not sure for now

avatar dgt41
dgt41 - comment - 26 Dec 2017

@Fedik do you have a branch with the code, can I take a look at?

avatar Fedik
Fedik - comment - 26 Dec 2017

this time I just made a quick tests to replace "jQuery UI sortable" , and then cleaned all ?
I will try to make something tomorrow, and will share

btw, this is also looks cool https://lukasoppermann.github.io/html5sortable/index.html
only problem that the mobiles does not support html5 dragable

avatar Fedik
Fedik - comment - 27 Dec 2017

@dgt41 there a test with use of their CDN 4.0-dev...Fedik:subform-sortable

there full example with custom element #19184

avatar brianteeman brianteeman - change - 25 Mar 2018
Labels Added: J4 Issue
avatar brianteeman brianteeman - labeled - 25 Mar 2018
avatar C-Lodder C-Lodder - change - 6 Mar 2019
The description was changed
avatar C-Lodder C-Lodder - edited - 6 Mar 2019
avatar C-Lodder C-Lodder - change - 6 Mar 2019
The description was changed
avatar C-Lodder C-Lodder - edited - 6 Mar 2019
avatar wilsonge wilsonge - change - 23 Apr 2019
The description was changed
avatar wilsonge wilsonge - edited - 23 Apr 2019
avatar C-Lodder C-Lodder - change - 27 Aug 2019
Status Discussion Closed
Closed_Date 0000-00-00 00:00:00 2019-08-27 14:10:58
Closed_By C-Lodder
avatar C-Lodder C-Lodder - close - 27 Aug 2019
avatar wilsonge
wilsonge - comment - 14 Mar 2020

PRs
Removal: #28341
Deprecation: #28342

Add a Comment

Login with GitHub to post a comment