? ? Pending

User tests: Successful: Unsuccessful:

avatar dgt41
dgt41
21 Nov 2017

Pull Request for Issue #18764 .

Summary of Changes

All index.php fallback to the same error page in case of unsupported PHP version. This should cover the cases @brianteeman mentioned in the issue:

  • downgrade php (perhaps by moving host)
  • use a hosting panel install script on an incompatible server (yes hosts are that stupid)

Testing Instructions

You need to edit each of the index.php files (root, installation, administrator) and change the line

if (version_compare(PHP_VERSION, JOOMLA_MINIMUM_PHP, '<'))

to

if (version_compare(PHP_VERSION, JOOMLA_MINIMUM_PHP, '>'))

and then navigate to
/
/installation/
/administrator/

or any other URI pointing in your server. All cases should respond with the nice html page.

Expected result

Actual result

Documentation Changes Required

Same as before, the js file for the translation is created through the gruntfile and the installation folder, so maintainers need to run the grunt installation to refresh that file if there are some changes in the languages files.

avatar dgt41 dgt41 - open - 21 Nov 2017
avatar dgt41 dgt41 - change - 21 Nov 2017
Status New Pending
avatar joomla-cms-bot joomla-cms-bot - change - 21 Nov 2017
Category JavaScript Repository Administration Installation Language & Strings Front End Templates (site)
avatar dgt41 dgt41 - change - 21 Nov 2017
Title
[4.0] dev proper html fallback everywhere
[4.0] proper html fallback everywhere
avatar dgt41 dgt41 - edited - 21 Nov 2017
avatar dgt41 dgt41 - change - 21 Nov 2017
The description was changed
avatar dgt41 dgt41 - edited - 21 Nov 2017
avatar wilsonge wilsonge - change - 22 Nov 2017
Status Pending Fixed in Code Base
Closed_Date 0000-00-00 00:00:00 2017-11-22 13:09:05
Closed_By wilsonge
Labels Added: ? ?
avatar wilsonge wilsonge - close - 22 Nov 2017
avatar wilsonge wilsonge - merge - 22 Nov 2017

Add a Comment

Login with GitHub to post a comment