Feeling Lucky
?
[#18751] - [4.0] Fix modal close for pagebreak
- Closed
- 21 Nov 2017
- Medium
- Build: 4.0-dev
- # 18751
- Diff
- C-Lodder:modalclose
User tests: Successful: Unsuccessful:
Pull Request for Issue #18733
Summary of Changes
The modal now closes once you insert a page break into an article
| Status | New | ⇒ | Pending |
joomla-cms-bot
- | Category | ⇒ | JavaScript |
C-Lodder
- comment
- 20 Nov 2017
Do the TinyMCE modals use jModalClose?
dgt41
- comment
- 20 Nov 2017
Yes, because apparently their modals are not booscrap (and why the should be?).
Anyhow there are couple of options here:
- Provide a solid API as I have proposed way back
- Modify the code in the modal section of bootstrap-init.js to expose a
jModalClosemethod. But let's not do this, personally I hate global functions...
C-Lodder
- comment
- 20 Nov 2017
Or just wait till CE?
brianteeman
- comment
- 20 Nov 2017
CE?
C-Lodder
- comment
- 20 Nov 2017
The modal custom element. Not idea what the verdict on that is though
dgt41
- comment
- 20 Nov 2017
The status of the modal custom element is:
- a11y tests passed
- API is not finalised
- we need solution for the sizing (css or js or a combo)
- we need to decide the final html structure of the modal
@C-Lodder we have to organise a meeting this week or the next one to move things forward
| Status | Pending | ⇒ | Closed |
| Closed_Date | 0000-00-00 00:00:00 | ⇒ | 2017-11-21 11:52:53 |
| Closed_By | ⇒ | C-Lodder | |
| Labels |
Added:
?
|
||
Nope. This will not work with the tinyMCE modals