Feeling Lucky
?
?
[#18742] - [4.0 ] Save custom field
- Closed
- 20 Nov 2017
- Medium
- Build: staging
- # 18742
- Diff
- joomla:4.0-dev
- Failure continuous-integration/drone/push the build failed Details
- Failure continuous-integration/travis-ci/push The Travis CI build failed Details
- Failure continuous-integration/appveyor/branch AppVeyor build failed Details
User tests: Successful: Unsuccessful:
Pull Request for Issue #18711
.
Summary of Changes
diff --git a/administrator/components/com_fields/Table/FieldTable.php b/administrator/components/com_fields/Table/FieldTable.php
index c7bc876..0efd355 100644
--- a/administrator/components/com_fields/Table/FieldTable.php
+++ b/administrator/components/com_fields/Table/FieldTable.php
@@ -112,7 +112,7 @@
$this->name = str_replace(',', '-', $this->name);
// Verify that the name is unique
-
$table = new Field($this->_db);
-
$table = new FieldTable($this->_db); if ($table->load(array('name' => $this->name)) && ($table->id != $this->id || $this->id == 0)) {
Testing Instructions
Create a new Custom Field in back end and save.
Expected result
Actual result
Field saved
Documentation Changes Required
No
| Status | New | ⇒ | Pending |
joomla-cms-bot
- | Category | ⇒ | Unit Tests Repository JavaScript Administration com_admin |
franz-wohlkoenig
- | Title |
|
||||||
| Labels |
Added:
?
?
|
||
| Status | Pending | ⇒ | Closed |
| Closed_Date | 0000-00-00 00:00:00 | ⇒ | 2017-11-20 11:23:55 |
| Closed_By | ⇒ | wilsonge |
All you've done here is request merging 4.0 into staging. But the fix in your description is correct so I've committed it with 78162da