Feeling Lucky
?
[#18584] - [3.9] Filesystem namespace
- Closed
- 7 Jan 2018
- Medium
- Build: 3.9-dev
- # 18584
- Diff
- fastslack:filesystem-ns-39
User tests: Successful: Unsuccessful:
Summary of Changes
Moved all libraries names to use namespace
Testing Instructions
Use as usual, all should work fine.
Expected result
No errors
| Status | New | ⇒ | Pending |
joomla-cms-bot
- | Category | ⇒ | Libraries Unit Tests |
| Labels |
Added:
?
?
|
||
mbabker
- comment
- 25 Dec 2017
Because of d88bc6b#diff-ab05fce3c8ea662bd591767ad671c853
You just need to merge the 3.9-dev branch into your branch and git should be able to work itself out (it sees there were modifications to the base file that aren't present in the moved file basically).
| Category | Libraries Unit Tests | ⇒ | Administration com_associations com_banners com_cache com_categories com_config com_contact com_content com_fields com_finder com_installer com_joomlaupdate com_languages com_login com_media |
| Labels |
Removed:
?
|
||
| Category | Administration com_associations com_banners com_cache com_categories com_config com_contact com_content com_fields com_finder com_installer com_joomlaupdate com_languages com_login com_media | ⇒ | Administration com_admin com_associations com_banners com_cache com_categories com_config com_contact com_content com_fields com_finder com_installer com_joomlaupdate |
fastslack
- comment
- 7 Jan 2018
Sorry i broke this, im going to open a new PR
| Status | Pending | ⇒ | Closed |
| Closed_Date | 0000-00-00 00:00:00 | ⇒ | 2018-01-07 17:53:19 |
| Closed_By | ⇒ | fastslack |
There are two unit tests failing. Can you have a look on them? After that it should be fine to get merged.