? Pending

User tests: Successful: Unsuccessful:

avatar fastslack
fastslack
13 Nov 2017

Filesystem namespace

Summary of Changes

Moved all libraries names to use namespace

Testing Instructions

Use as usual, all should work fine.

Expected result

No errors

3af4d38 13 Nov 2017 avatar fastslack Ups
avatar fastslack fastslack - open - 13 Nov 2017
avatar fastslack fastslack - change - 13 Nov 2017
Status New Pending
avatar joomla-cms-bot joomla-cms-bot - change - 13 Nov 2017
Category Libraries
avatar fastslack fastslack - change - 13 Nov 2017
Labels Added: ?
avatar joomla-cms-bot joomla-cms-bot - change - 13 Nov 2017
Category Libraries Libraries Unit Tests
avatar fastslack fastslack - change - 13 Nov 2017
Labels Added: ?
avatar joomla-cms-bot joomla-cms-bot - change - 13 Nov 2017
Category Libraries Unit Tests Libraries
avatar laoneo
laoneo - comment - 14 Nov 2017

Thank you very much. The wrappers can't be deleted on Joomla 3.9, after this one gets merged, we can then delete them in the 4.0 branch as we did with the other wrappers. I guess for the rest we can slowly migrate the code then to the framework filesystem package internally.

avatar fastslack
fastslack - comment - 16 Nov 2017

Closing this, i ll open a new one soon with wrappers

avatar fastslack fastslack - change - 16 Nov 2017
Status Pending Closed
Closed_Date 0000-00-00 00:00:00 2017-11-16 12:57:39
Closed_By fastslack
Labels Removed: ?
avatar fastslack fastslack - close - 16 Nov 2017
avatar laoneo
laoneo - comment - 16 Nov 2017

Or just add the files again and commit them to the branch then you should be good to go, no need to close it.

avatar fastslack
fastslack - comment - 16 Nov 2017

But if i add the files i ll lose all git logs, also i need to change others files that point to wrappers. Dont worry i can do it fast using the patches

avatar laoneo
laoneo - comment - 16 Nov 2017

Not sure if your really loose the logs. Which files have been using the wrappers. Probably you can leave them as we are going to remove the wrappers in 4 anyway.

avatar fastslack
fastslack - comment - 16 Nov 2017

Its done here: #18584

Add a Comment

Login with GitHub to post a comment