User tests: Successful: Unsuccessful:
Filesystem namespace
Moved all libraries names to use namespace
Use as usual, all should work fine.
No errors
Status | New | ⇒ | Pending |
Category | ⇒ | Libraries |
Labels |
Added:
?
|
Category | Libraries | ⇒ | Libraries Unit Tests |
Labels |
Added:
?
|
Category | Libraries Unit Tests | ⇒ | Libraries |
Closing this, i ll open a new one soon with wrappers
Status | Pending | ⇒ | Closed |
Closed_Date | 0000-00-00 00:00:00 | ⇒ | 2017-11-16 12:57:39 |
Closed_By | ⇒ | fastslack | |
Labels |
Removed:
?
|
Or just add the files again and commit them to the branch then you should be good to go, no need to close it.
But if i add the files i ll lose all git logs, also i need to change others files that point to wrappers. Dont worry i can do it fast using the patches
Not sure if your really loose the logs. Which files have been using the wrappers. Probably you can leave them as we are going to remove the wrappers in 4 anyway.
Thank you very much. The wrappers can't be deleted on Joomla 3.9, after this one gets merged, we can then delete them in the 4.0 branch as we did with the other wrappers. I guess for the rest we can slowly migrate the code then to the framework filesystem package internally.