[#18564] - Make sure the view exists before adding it to the menu lookup array, remove PHP Notices
- Fixed in Code Base
- 18 Nov 2017
- Medium
- Build: staging
- # 18564
- Diff
- csthomas:menu_lookup_check_view_name
User tests: Successful: Unsuccessful:
Other solution for the same problem as in #17323, #18043
Summary of Changes
Do not add view name to the menu lookup array if the view does not exists.
Remove PHP Notice:
Notice: Undefined index: loginx in .../libraries/src/Component/Router/Rules/MenuRules.php on line 216
Notice: Trying to get property of non-object in .../libraries/src/Component/Router/Rules/MenuRules.php on line 216
Testing Instructions
-
Install joomla.
-
Go to backend and edit a menu item.
-
Change name of view in the link field and save.
Please see attached video. I used FF Inspector (Ctrl + Shift + C)
-
Go to frontend in order to see changes.
-
Before PR there are 2 php notices, after PR they disappear.
Expected result
No PHP Notices
Actual result
PHP Notices.
Documentation Changes Required
No
| Status | New | ⇒ | Pending |
joomla-cms-bot
- | Category | ⇒ | Libraries |
I have tested this item
Both PHP errors gone with PR.
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/18564.
In your video, after clicking the Save button, the Menu Item Type is blank. Is that right?
Yes, view loginx has never exist.
View sectionexisted in older joomla version but you will get the same result, blank menu type.
I do not have other idea how to test old menu item that currently does not exists.
This is only a example (a way) to create a menu item that for now does not exist, like with view section.
After you create invalid menu item, means with view that is invalid then you get php notices - on front end - before PR.
I have tested this item
Tested like in the instructions. Nice gif btw!
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/18564.
| Status | Pending | ⇒ | Ready to Commit |
RTC after two successful tests.
mbabker
- | Status | Ready to Commit | ⇒ | Fixed in Code Base |
| Closed_Date | 0000-00-00 00:00:00 | ⇒ | 2017-11-18 15:11:06 |
| Closed_By | ⇒ | mbabker | |
| Labels |
Added:
?
|
||
Anyone who has tested this PR can login at https://issues.joomla.org/tracker/joomla-cms/18564 and mark the test as successful.