Joomla! Issue Tracker - CMS

Download
Launch
Feeling Lucky

[#18508] - Restore Tab functionality in forms with calendars

? ? Pending

User tests: Successful: Unsuccessful:

avatar Bakual
Bakual
6 Nov 2017

Pull Request for Issue #18448 .

Summary of Changes

Removes the line document.activeElement.blur(); as discussed and proposed by @dgt41 in referenced issue.

Testing Instructions

Test with Internet Explorer 11, Edge or Safari to use the Tabulator key to navigate through a form that contains calendar elements. Eg the article form.

Expected result

You can navigate without issues

Actual result

After hitting the calendar field, you start over at the very top of the page. Elements "behind" the calendar are not accesssible anymore.

Documentation Changes Required

None

avatar Bakual Bakual - open - 6 Nov 2017
avatar Bakual Bakual - change - 6 Nov 2017
Status New ⇒ Pending
avatar joomla-cms-bot joomla-cms-bot - change - 6 Nov 2017
Category ⇒ JavaScript
avatar franz-wohlkoenig
franz-wohlkoenig - comment - 6 Nov 2017

With and -out PR can

  • tab through Fields in Article-Publishing-Tab.
  • if press "Space" at Calendar-Field, Field opens, after "Tab" or "Escape" Focus is on "Save"-Button.

System information

3.8.2-rc
Multilanguage Site
macOS Sierra, 10.12.6
Safari 11.0.1

MAMP 4.1.1

avatar Bakual
Bakual - comment - 6 Nov 2017

Please test with IE/Edge then. I haven't tested with Safari myself. That one was mentioned by Dimitris.

avatar franz-wohlkoenig
franz-wohlkoenig - comment - 6 Nov 2017

to be honest: no IE/Edge.

avatar Quy Quy - test_item - 13 Nov 2017 - Tested successfully
avatar Quy
Quy - comment - 13 Nov 2017

I have tested this item ✅ successfully on 64adadf

This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/18508.

avatar Bakual Bakual - change - 4 Dec 2017
Labels Added: ?
avatar Bakual Bakual - change - 4 Dec 2017
The description was changed
avatar Bakual Bakual - edited - 4 Dec 2017
avatar gwsdesk gwsdesk - test_item - 5 Dec 2017 - Tested successfully
avatar gwsdesk
gwsdesk - comment - 5 Dec 2017

I have tested this item ✅ successfully on 001d46f

Tested in Edge as requested and works as expected on a Joomla 3.8.2 install

This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/18508.

avatar gwsdesk
gwsdesk - comment - 5 Dec 2017

Tested with IE11 as well as Edge. Works as expected

This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/18508.

avatar franz-wohlkoenig
franz-wohlkoenig - comment - 5 Dec 2017

@Quy can you please retest?

avatar Quy Quy - test_item - 5 Dec 2017 - Tested successfully
avatar Quy
Quy - comment - 5 Dec 2017

I have tested this item ✅ successfully on 001d46f

This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/18508.

avatar franz-wohlkoenig franz-wohlkoenig - change - 5 Dec 2017
Status Pending ⇒ Ready to Commit
avatar franz-wohlkoenig
franz-wohlkoenig - comment - 5 Dec 2017

Ready to Commit after two successful tests.

avatar infograf768
infograf768 - comment - 6 Dec 2017

@mbabker
Milestone?

avatar mbabker mbabker - change - 6 Dec 2017
Status Ready to Commit ⇒ Fixed in Code Base
Closed_Date 0000-00-00 00:00:00 ⇒ 2017-12-06 14:44:34
Closed_By ⇒ mbabker
Labels Added: ?
avatar mbabker mbabker - close - 6 Dec 2017
avatar mbabker mbabker - merge - 6 Dec 2017

Add a Comment

Login with GitHub to post a comment