[#18416] - [installer] - sanitize extensions type as lower case
- Fixed in Code Base
- 25 Jan 2018
- Medium
- Build: staging
- # 18416
- Diff
- alikon:patch-69
User tests: Successful: Unsuccessful:
Pull Request for Issue #18412.
Summary of Changes
the #__extensions.type field is stored as lower case
Testing Instructions
see #18412
you can test with weblinks https://github.com/joomla-extensions/weblinks/releases
Expected result
same behaviuor as mysql
Actual result
installed twice on postgresql
Votes
joomla-cms-bot
- | Category | ⇒ | Libraries |
| Status | New | ⇒ | Pending |
| Category | Libraries | ⇒ | Libraries Postgresql |
Hope it will add in core soon.
@nayemmajhar Please mark test as success at https://issues.joomla.org/tracker/joomla-cms/18416
After 2 success tests this PR can go forward.
@nayemmajhar how to mark your Test as successfully:
- open Issue Tracker
- Login with your github-Account
- Click on blue "Test this"-Button above Authors-Picture
- mark your Test as successfully
- hit "submit test result"
@alikon This fix is not working as expected. Here is why ModuleAdapter class extends from InstallerAdapter class and checkExistingExtension method override by ModuleAdapter. So still it's duplicating extension in #__extensions and #__modules table. I think #19402 is correct to fix this issue.
I have attached an Image of #__extensions table from your fix.
I have tested this item
It only works for Component installation. Here is another request for module & plugins issue. #19402 We can check that too.
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/18416.
| Status | Pending | ⇒ | Ready to Commit |
Ready to Commit after two successful tests.
Hope you will merge soon. PostgreSQL users badly need this fix.
mbabker
- | Status | Ready to Commit | ⇒ | Fixed in Code Base |
| Closed_Date | 0000-00-00 00:00:00 | ⇒ | 2018-01-25 13:24:14 |
| Closed_By | ⇒ | mbabker | |
| Labels |
Added:
?
|
||
| Category | Libraries Postgresql | ⇒ | Libraries |
I have tested this item✅ successfully on e24340d
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/18416.