[#18415] - Do not force HTML5 polyfill on modern browsers
- Fixed in Code Base
- 1 Nov 2017
- Medium
- Build: staging
- # 18415
- Diff
- dgt41:§staging-conditional-html4
User tests: Successful: Unsuccessful:
Pull Request for Issue #18199 (comment).
Summary of Changes
Whenever a field is rendered the HTML5 polyfill is injected and used. This is not performant and also the polyfill causes weird effects on modern browsers. So let's load it conditionally on for old IE 8.
Testing Instructions
Check #18199 (comment)
Apply the patch and check again, there shouldn't be a weird behaviour
Expected result
Everything works as expected
Actual result
Polyfill can cause weird behaviour hick ups on modern browsers
Documentation Changes Required
NONE
joomla-cms-bot
- | Category | ⇒ | Layout Libraries Modules Front End |
| Status | New | ⇒ | Pending |
| Labels |
Added:
?
|
||
It is still an issue with Firefox 56.0.1 on Windows 10. Cleared cache.
It's a browser bug. Non-Joomla project using number input fields, Firefox 56 on MacOS 10.12, set it as readonly and get the arrow controls there.
I would remove it at all, it is useless piece of code.
As far as I remember it only for "placeholder" fallback.
@Fedik unfortunately it a bit more than placeholders:
var attributes = [ 'required', 'pattern', 'placeholder', 'autofocus', 'formnovalidate' ],
types = [ 'email', 'url', 'number', 'range' ],But doing it this way it will only be loaded for IE8 so you should be good for most real use cases
I have tested this item
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/18415.
I have tested this item
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/18415.
| Status | Pending | ⇒ | Ready to Commit |
RTC after two successful tests.
| Status | Ready to Commit | ⇒ | Fixed in Code Base |
| Closed_Date | 0000-00-00 00:00:00 | ⇒ | 2017-11-01 12:05:41 |
| Closed_By | ⇒ | mbabker | |
| Labels |
Added:
?
|
||
Keep it as number. There is no point in penalizing other users because one implementation has a bug.
It shouldn't affect users since it is readonly other than displaying the arrow controls when it shouldn't in Firefox.
If it really becomes a major problem there are CSS tricks that can be used to hide them.
Remove extra space after 9 in
<!--[if lt IE 9 ].