[#18408] - [fix] Display subcategories in blog layout only when user has access
- Fixed in Code Base
- 27 Oct 2017
- Medium
- Build: staging
- # 18408
- Diff
- infograf768:sucatinblog
- Pending continuous-integration/drone/pr this build is pending Details
User tests: Successful: Unsuccessful:
Pull Request for Issue #18397
Summary of Changes
Check access to subcategories.
Testing Instructions
See #18397
Before patch, subcategories display even if they are set to registered access. Clicking on their title gets a 403.
After patch the registered subcategories do not display until the user has logged in.
joomla-cms-bot
- | Category | ⇒ | Front End com_content |
| Status | New | ⇒ | Pending |
@infograf768 there is only one changed line in the pr
Nope. You have only seen +$user = JFactory::getUser();
look further and please test
+ <?php $groups = $user->getAuthorisedViewLevels(); ?>
+ <?php // Check whether category access level allows access to subcategories. ?>
+ <?php if (in_array($child->access, $groups)) : ?>
and obvioulsy a new endif before endforeach
| Labels |
Added:
?
|
||
Needs tests, folks. thanks.
I have tested this item
tested successfully for article category blog but shouldnt the same change be made for article category list
luckily the contacts component does not have the same issue
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/18408.
I have tested this item
It would be good to do the same for beez3 template?
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/18408.
| Status | Pending | ⇒ | Ready to Commit |
RTC after two successful tests.
yes to both i.e list and beez.
Based on comments does this need further updates?
| Labels |
Added:
?
|
||
| Category | Front End com_content | ⇒ | Front End com_content Templates (site) |
Updated:
Added similar code for category list and blog/list for Beez.
@brianteeman
@csthomas
Please test again
| Status | Ready to Commit | ⇒ | Pending |
| Labels | |||
Restarted travis as php 5.6 did not complete.
I have tested this item
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/18408.
I have tested this item
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/18408.
| Status | Pending | ⇒ | Ready to Commit |
RTC after two successful tests.
| Title |
|
||||||
| Status | Ready to Commit | ⇒ | Fixed in Code Base |
| Closed_Date | 0000-00-00 00:00:00 | ⇒ | 2017-10-27 13:35:32 |
| Closed_By | ⇒ | mbabker | |
| Labels | |||
Indentation had to be changed which explains why this patch looks so big.
real code changes are very small.