PR-staging RTC

Pending

User tests: Successful: Unsuccessful:

avatar infograf768
infograf768
24 Oct 2017

Pull Request for Issue #18397

Summary of Changes

Check access to subcategories.

Testing Instructions

See #18397

Before patch, subcategories display even if they are set to registered access. Clicking on their title gets a 403.

After patch the registered subcategories do not display until the user has logged in.

avatar joomla-cms-bot joomla-cms-bot - change - 24 Oct 2017
Category Front End com_content
avatar infograf768 infograf768 - open - 24 Oct 2017
avatar infograf768 infograf768 - change - 24 Oct 2017
Status New Pending
avatar infograf768
infograf768 - comment - 24 Oct 2017

Indentation had to be changed which explains why this patch looks so big.
real code changes are very small.

avatar brianteeman
brianteeman - comment - 24 Oct 2017

@infograf768 there is only one changed line in the pr

avatar infograf768
infograf768 - comment - 24 Oct 2017

Nope. You have only seen +$user = JFactory::getUser();
look further and please test

+		<?php $groups = $user->getAuthorisedViewLevels(); ?>
+		<?php // Check whether category access level allows access to subcategories. ?>
+		<?php if (in_array($child->access, $groups)) : ?>

and obvioulsy a new endif before endforeach

avatar infograf768 infograf768 - change - 25 Oct 2017
Labels Added: PR-staging
avatar infograf768
infograf768 - comment - 25 Oct 2017

Needs tests, folks. thanks.

avatar brianteeman brianteeman - test_item - 25 Oct 2017 - Tested successfully
avatar brianteeman
brianteeman - comment - 25 Oct 2017

I have tested this item successfully on 3e34671

tested successfully for article category blog but shouldnt the same change be made for article category list

luckily the contacts component does not have the same issue


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/18408.

avatar csthomas csthomas - test_item - 25 Oct 2017 - Tested successfully
avatar csthomas
csthomas - comment - 25 Oct 2017

I have tested this item successfully on 3e34671

It would be good to do the same for beez3 template?


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/18408.

avatar franz-wohlkoenig franz-wohlkoenig - change - 25 Oct 2017
Status Pending Ready to Commit
avatar franz-wohlkoenig
franz-wohlkoenig - comment - 25 Oct 2017

RTC after two successful tests.

avatar infograf768
infograf768 - comment - 25 Oct 2017

yes to both i.e list and beez.

avatar mbabker
mbabker - comment - 26 Oct 2017

Based on comments does this need further updates?

avatar infograf768
infograf768 - comment - 26 Oct 2017

Will try to update today for list and beez, if OK for you @mbabker

avatar infograf768 infograf768 - change - 26 Oct 2017
Labels Added: RTC
avatar joomla-cms-bot joomla-cms-bot - change - 26 Oct 2017
Category Front End com_content Front End com_content Templates (site)
avatar infograf768
infograf768 - comment - 26 Oct 2017

Updated:
Added similar code for category list and blog/list for Beez.

@brianteeman
@csthomas
Please test again

avatar infograf768 infograf768 - change - 26 Oct 2017
Status Ready to Commit Pending
Labels
avatar infograf768
infograf768 - comment - 26 Oct 2017

Restarted travis as php 5.6 did not complete.

avatar csthomas csthomas - test_item - 26 Oct 2017 - Tested successfully
avatar csthomas
csthomas - comment - 26 Oct 2017

I have tested this item successfully on 6a6e91d


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/18408.

avatar franz-wohlkoenig franz-wohlkoenig - test_item - 26 Oct 2017 - Tested successfully
avatar franz-wohlkoenig
franz-wohlkoenig - comment - 26 Oct 2017

I have tested this item successfully on 6a6e91d


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/18408.

avatar franz-wohlkoenig franz-wohlkoenig - change - 26 Oct 2017
Status Pending Ready to Commit
avatar franz-wohlkoenig
franz-wohlkoenig - comment - 26 Oct 2017

RTC after two successful tests.

avatar joomla-cms-bot joomla-cms-bot - edited - 27 Oct 2017
avatar franz-wohlkoenig franz-wohlkoenig - change - 27 Oct 2017
Title
[fix] Display subcategories in blog layout only when user has access.
[fix] Display subcategories in blog layout only when user has access
avatar mbabker mbabker - change - 27 Oct 2017
Status Ready to Commit Fixed in Code Base
Closed_Date 0000-00-00 00:00:00 2017-10-27 13:35:32
Closed_By mbabker
Labels
avatar mbabker mbabker - close - 27 Oct 2017
avatar mbabker mbabker - merge - 27 Oct 2017

Add a Comment

Login with GitHub to post a comment