[#18407] - [com_tags] Always use slug to create tag links
- Fixed in Code Base
- 1 Nov 2017
- Medium
- Build: staging
- # 18407
- Diff
- csthomas:fix_tag_links
User tests: Successful: Unsuccessful:
Pull Request for Issue partly for #18363.
Summary of Changes
Create a link to tag always using slug=id:alias, I mean replace '-' to ':' and add alias to id if missing.
Testing Instructions
- Install joomla staging with sample data testing
- At home page the is a search box, search for existed tag 'lime' (
../index.php/search?searchword=lime&searchphrase=all)- you should get incorrect link to tag (only id):
.../index.php/all-tags/5
- you should get incorrect link to tag (only id):
- Apply patch and refresh page or search again.
- now you get correct link:
../index.php/all-tags/lime
- now you get correct link:
This is a link to set status of test https://issues.joomla.org/tracker/joomla-cms/18407
Expected result
Links to tag view should always use alias.
When SEF is disabled then tag id is equal to id:alias not id-alias
Actual result
Joomla generates different links to the same tag.
Documentation Changes Required
No
joomla-cms-bot
- | Category | ⇒ | com_tags Front End Layout Modules Plugins |
| Status | New | ⇒ | Pending |
No.
This PR fix process of creating URL in plugin search tags, which generate wrong URL (without alias). This is probably the reason that you found a bad url like /tag/4.
In above test instruction you can find a place where the wrong URL exists.
After 2 success tests this PR can be merged.
For canonical URLs please create a new issue.
@niaziblog @eSilverStrike
Could you test this PR?
This PR does not add canonical URL but fixes URL generated by search plugin and in other places.
It should help a little.
Seems to work for me.
@eSilverStrike please mark your Test as successfully:
- open Issue Tracker
- Login with your github-Account
- Click on blue "Test this"-Button above Authors-Picture
- mark your Test as successfully
- hit "submit test result"
I have tested this item
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/18407.
I have tested this item
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/18407.
| Status | Pending | ⇒ | Ready to Commit |
RTC after two successful tests.
mbabker
- | Status | Ready to Commit | ⇒ | Fixed in Code Base |
| Closed_Date | 0000-00-00 00:00:00 | ⇒ | 2017-11-01 12:05:07 |
| Closed_By | ⇒ | mbabker | |
| Labels |
Added:
?
|
||
Was canonical URLs added to this fix as well? If not I will add a new issue about canonical URLs for the Tags Component since they are needed to help Google figure out which URL should be used in the search results.