RTC

Pending

User tests: Successful: Unsuccessful:

avatar csthomas
csthomas
24 Oct 2017

Pull Request for Issue partly for #18363.

Summary of Changes

Create a link to tag always using slug=id:alias, I mean replace '-' to ':' and add alias to id if missing.

Testing Instructions

  1. Install joomla staging with sample data testing
  2. At home page the is a search box, search for existed tag 'lime' (../index.php/search?searchword=lime&searchphrase=all)
    • you should get incorrect link to tag (only id): .../index.php/all-tags/5
  3. Apply patch and refresh page or search again.
    • now you get correct link: ../index.php/all-tags/lime

This is a link to set status of test https://issues.joomla.org/tracker/joomla-cms/18407

Expected result

Links to tag view should always use alias.
When SEF is disabled then tag id is equal to id:alias not id-alias

Actual result

Joomla generates different links to the same tag.

Documentation Changes Required

No

avatar joomla-cms-bot joomla-cms-bot - change - 24 Oct 2017
Category com_tags Front End Layout Modules Plugins
avatar csthomas csthomas - open - 24 Oct 2017
avatar csthomas csthomas - change - 24 Oct 2017
Status New Pending
avatar eSilverStrike
eSilverStrike - comment - 24 Oct 2017

Was canonical URLs added to this fix as well? If not I will add a new issue about canonical URLs for the Tags Component since they are needed to help Google figure out which URL should be used in the search results.

avatar csthomas
csthomas - comment - 24 Oct 2017

No.

This PR fix process of creating URL in plugin search tags, which generate wrong URL (without alias). This is probably the reason that you found a bad url like /tag/4.
In above test instruction you can find a place where the wrong URL exists.

After 2 success tests this PR can be merged.

For canonical URLs please create a new issue.

avatar csthomas
csthomas - comment - 24 Oct 2017

There is also another PR #15479, which fix problem with duplicate links in tags.

avatar csthomas csthomas - change - 24 Oct 2017
The description was changed
avatar csthomas csthomas - edited - 24 Oct 2017
avatar csthomas csthomas - change - 25 Oct 2017
The description was changed
avatar csthomas csthomas - edited - 25 Oct 2017
avatar csthomas
csthomas - comment - 26 Oct 2017

@niaziblog @eSilverStrike
Could you test this PR?

This PR does not add canonical URL but fixes URL generated by search plugin and in other places.
It should help a little.

avatar eSilverStrike
eSilverStrike - comment - 27 Oct 2017

Seems to work for me.

avatar franz-wohlkoenig
franz-wohlkoenig - comment - 27 Oct 2017

@eSilverStrike please mark your Test as successfully:

  • open Issue Tracker
  • Login with your github-Account
  • Click on blue "Test this"-Button above Authors-Picture
  • mark your Test as successfully
  • hit "submit test result"
avatar alikon alikon - test_item - 27 Oct 2017 - Tested successfully
avatar alikon
alikon - comment - 27 Oct 2017

I have tested this item successfully on 38583da


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/18407.

avatar eSilverStrike eSilverStrike - test_item - 27 Oct 2017 - Tested successfully
avatar eSilverStrike
eSilverStrike - comment - 27 Oct 2017

I have tested this item successfully on 38583da


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/18407.

avatar franz-wohlkoenig franz-wohlkoenig - change - 28 Oct 2017
Status Pending Ready to Commit
avatar franz-wohlkoenig
franz-wohlkoenig - comment - 28 Oct 2017

RTC after two successful tests.

avatar mbabker mbabker - change - 1 Nov 2017
Status Ready to Commit Fixed in Code Base
Closed_Date 0000-00-00 00:00:00 2017-11-01 12:05:07
Closed_By mbabker
Labels Added: RTC
avatar mbabker mbabker - close - 1 Nov 2017
avatar mbabker mbabker - merge - 1 Nov 2017

Add a Comment

Login with GitHub to post a comment