[#18395] - Allow to connect to redis by socket
- Fixed in Code Base
- 24 Nov 2017
- Medium
- Build: staging
- # 18395
- Diff
- csthomas:redis_improvement
- Pending hound Hound is busy reviewing changes... Details
- Pending continuous-integration/drone/pr this build is pending Details
User tests: Successful: Unsuccessful:
Summary of Changes
Further development of #18266
Inspired by #15822, #17528 and my own #16904
-
Allow to connect to Redis by socket (cache and session handler).
- check first character of supplied server host to check if it is a socket path or not.
-
Fix for "CLI scripts print 'Application Instantiation Error' when redis cache enabled" but without breaking B/C.
- use
\JFactory::getApplication()only if needed, this way redis can be use on CLI script, see #16904.
- use
-
Add support for Redis Authentication in Session handler, the same as in cache handler.
-
Add option to set/unset persistent connection in Session Redis handler.
More info:
- phpredis/phpredis#284 (comment)
- https://github.com/phpredis/phpredis#user-content-php-session-handler
Before
After
Testing Instructions
Test cache and session handler using Redis by socket.
Expected result
All works as expected.
Actual result
Redis by socket is not available.
Documentation Changes Required
Maybe
joomla-cms-bot
- | Category | ⇒ | Administration com_config Libraries |
| Status | New | ⇒ | Pending |
| Labels |
Added:
?
|
||
I have tested this item
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/18395.
I have tested this item
For me is OK! I have tested the socket and auth both for cache and session.
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/18395.
Thank you all for testing
| Status | Pending | ⇒ | Ready to Commit |
RTC
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/18395.
mbabker
- | Status | Ready to Commit | ⇒ | Fixed in Code Base |
| Closed_Date | 0000-00-00 00:00:00 | ⇒ | 2017-11-24 18:11:57 |
| Closed_By | ⇒ | mbabker | |
| Labels |
Added:
?
|
||
@simbus82 can you please test this PR?
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/18395.