? ? Pending

User tests: Successful: Unsuccessful:

avatar brianteeman
brianteeman
21 Oct 2017

Document has multiple elements with the same id attribute: batch-choose-action. An id attribute has to be unique. This PR resolves this in the same way as similar batch modals

There is no visual difference

avatar joomla-cms-bot joomla-cms-bot - change - 21 Oct 2017
Category Administration com_users
avatar brianteeman brianteeman - open - 21 Oct 2017
avatar brianteeman brianteeman - change - 21 Oct 2017
Status New Pending
27db583 22 Dec 2017 avatar brianteeman id
avatar brianteeman brianteeman - change - 22 Dec 2017
Labels Added: ?
avatar Quy Quy - test_item - 23 Dec 2017 - Tested successfully
avatar Quy
Quy - comment - 23 Dec 2017

I have tested this item successfully on 27db583


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/18377.

avatar franz-wohlkoenig
franz-wohlkoenig - comment - 23 Dec 2017

@Quy can you write how you have tested?

avatar Quy
Quy - comment - 23 Dec 2017

In backend, go to Users > Manage.
Check 2 users.
Click Batch button.

The modal will look the same before and after the PR.

avatar alikon alikon - test_item - 23 Dec 2017 - Tested successfully
avatar alikon
alikon - comment - 23 Dec 2017

I have tested this item successfully on 27db583


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/18377.

avatar franz-wohlkoenig franz-wohlkoenig - change - 23 Dec 2017
Status Pending Ready to Commit
avatar franz-wohlkoenig
franz-wohlkoenig - comment - 23 Dec 2017

Ready to Commit after two successful tests.

Thanks @Quy, @alikon was faster.

avatar mbabker mbabker - close - 23 Dec 2017
avatar mbabker mbabker - merge - 23 Dec 2017
avatar mbabker mbabker - change - 23 Dec 2017
Status Ready to Commit Fixed in Code Base
Closed_Date 0000-00-00 00:00:00 2017-12-23 16:01:18
Closed_By mbabker
Labels Added: ?
avatar brianteeman
brianteeman - comment - 23 Dec 2017

Thanks

Add a Comment

Login with GitHub to post a comment