@mbabker

But what changes in the core have made this problem as this has worked for years. Surely that is the "bug" to find and fix. This is just a band aid to mask the "bug"

This PR is now only for beez3 and protostar templates.

[UPDATED]

By replacing search to mod_search you will always get some module, if mod_search is disabled or only set for some menu items then you get dummy object but render mod_search without any parameters from db.

The $this->getBuffer() change is because only the HTML document type really has the concept of module positions, error pages use the Error document type and that doesn't. So you have to manually render the module.

As for search versus mod_search, as I said in the other issue it shouldn't matter which you do as long as the module load process goes correctly. If it doesn't go correctly or plugins are messing with the result set, it's possible the name isn't there (though since the object is an unkeyed stdClass and not a proper data object in theory the module isn't reliable either).

The part with removing $this->getBuffer() is OK, I would not replace search by mod_search

I want to say that if the module will be disabled/removed then it will still be displayed on error page.

I want to say that if the module will be disabled/removed then it will still be displayed on error page.

Well, this very easily balloons into a bigger patch. Because:

• The module should be configurable based on what search your site uses (right now it's hardcoded)
• If you don't use a search engine in your site, then the text should not hint towards searching

For that first part, what we do in the joomla.org template is add a parameter to the template style to choose between mod_finder and mod_search to at least let the module use the site's active search component, we didn't account for the no search scenario though and to deal with a "well this site uses a custom search" thing you'd have to hook the form through the normal plugin events to add your option.

For what this is right now, it's fine I would say.

I have tested this item ✅ successfully on b691428

I have tested this item ✅ successfully on b691428

RTC after two successful tests.