RTC

Pending

User tests: Successful: Unsuccessful:

avatar infograf768
infograf768
20 Oct 2017

Testing Instructions

Display the error page with Protostar or Beez with a link like
mydomain.com/whatever

Expected result

The search module should display

Actual result

It does not not display

Patch and test again

You should get for Protostar
screen shot 2017-10-20 at 18 01 59

and for Beez

screen shot 2017-10-20 at 18 03 40

avatar joomla-cms-bot joomla-cms-bot - change - 20 Oct 2017
Category Front End Templates (site)
avatar infograf768 infograf768 - open - 20 Oct 2017
avatar infograf768 infograf768 - change - 20 Oct 2017
Status New Pending
avatar infograf768
infograf768 - comment - 20 Oct 2017
avatar brianteeman
brianteeman - comment - 20 Oct 2017

But what changes in the core have made this problem as this has worked for years. Surely that is the "bug" to find and fix. This is just a band aid to mask the "bug"

avatar csthomas
csthomas - comment - 20 Oct 2017

This PR is now only for beez3 and protostar templates.

[UPDATED]

By replacing search to mod_search you will always get some module, if mod_search is disabled or only set for some menu items then you get dummy object but render mod_search without any parameters from db.

avatar mbabker
mbabker - comment - 20 Oct 2017

The $this->getBuffer() change is because only the HTML document type really has the concept of module positions, error pages use the Error document type and that doesn't. So you have to manually render the module.

As for search versus mod_search, as I said in the other issue it shouldn't matter which you do as long as the module load process goes correctly. If it doesn't go correctly or plugins are messing with the result set, it's possible the name isn't there (though since the object is an unkeyed stdClass and not a proper data object in theory the module isn't reliable either).

avatar csthomas
csthomas - comment - 20 Oct 2017

The part with removing $this->getBuffer() is OK, I would not replace search by mod_search

avatar csthomas
csthomas - comment - 20 Oct 2017

I want to say that if the module will be disabled/removed then it will still be displayed on error page.

avatar mbabker
mbabker - comment - 20 Oct 2017

I want to say that if the module will be disabled/removed then it will still be displayed on error page.

Well, this very easily balloons into a bigger patch. Because:

  • The module should be configurable based on what search your site uses (right now it's hardcoded)
  • If you don't use a search engine in your site, then the text should not hint towards searching

For that first part, what we do in the joomla.org template is add a parameter to the template style to choose between mod_finder and mod_search to at least let the module use the site's active search component, we didn't account for the no search scenario though and to deal with a "well this site uses a custom search" thing you'd have to hook the form through the normal plugin events to add your option.

For what this is right now, it's fine I would say.

avatar csthomas csthomas - test_item - 20 Oct 2017 - Tested successfully
avatar csthomas
csthomas - comment - 20 Oct 2017

I have tested this item successfully on b691428


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/18375.

avatar alikon alikon - test_item - 21 Oct 2017 - Tested successfully
avatar alikon
alikon - comment - 21 Oct 2017

I have tested this item successfully on b691428


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/18375.

avatar franz-wohlkoenig franz-wohlkoenig - change - 21 Oct 2017
Status Pending Ready to Commit
avatar franz-wohlkoenig
franz-wohlkoenig - comment - 21 Oct 2017

RTC after two successful tests.

avatar mbabker mbabker - change - 23 Oct 2017
Status Ready to Commit Fixed in Code Base
Closed_Date 0000-00-00 00:00:00 2017-10-23 23:24:20
Closed_By mbabker
Labels Added: RTC
avatar mbabker mbabker - close - 23 Oct 2017
avatar mbabker mbabker - merge - 23 Oct 2017

Add a Comment

Login with GitHub to post a comment