[#18372] - JED message invalid html
- Fixed in Code Base
- 18 Dec 2017
- Medium
- Build: staging
- # 18372
- Diff
- brianteeman:jedoptions
- Success hound No violations found. Woof! Details
- Success continuous-integration/drone/pr the build was successful Details
- Success continuous-integration/travis-ci/pr The Travis CI build passed Details
- Success continuous-integration/appveyor/pr AppVeyor build succeeded Details
User tests: Successful: Unsuccessful:
The cog icon link in the Install JED message in the installer is invalid html as there is nothing inside the a link. This pr fixes that in an accessible way. There is no visual change
| Category | ⇒ | Code style |
| Status | New | ⇒ | Information Required |
| Milestone |
Added: |
||
Go to Extensions > Manage.
View page source.
Before PR
<a href="/joomla-cms-staging/administrator/index.php?option=com_config&view=component&component=com_installer&path=&return=aHR0cDovL2xvY2FsaG9zdC9qb29tbGEtY21zLXN0YWdpbmcvYWRtaW5pc3RyYXRvci9pbmRleC5waHA%2Fb3B0aW9uPWNvbV9pbnN0YWxsZXI%3D" class="alert-options hasTooltip icon-options" data-dismiss="alert" title="Opens Installer Options for setting to hide this Joomla! Extensions Directory™ message."></a>
After PR added <span class="element-invisible">Opens Installer Options for setting to hide this Joomla! Extensions Directory™ message.</span>
<a href="/joomla-cms-staging/administrator/index.php?option=com_config&view=component&component=com_installer&path=&return=aHR0cDovL2xvY2FsaG9zdC9qb29tbGEtY21zLXN0YWdpbmcvYWRtaW5pc3RyYXRvci9pbmRleC5waHA%2Fb3B0aW9uPWNvbV9pbnN0YWxsZXI%3D" class="alert-options hasTooltip icon-options" data-dismiss="alert" title="Opens Installer Options for setting to hide this Joomla! Extensions Directory™ message."><span class="element-invisible">Opens Installer Options for setting to hide this Joomla! Extensions Directory™ message.</span></a>
There isn't an entry for this PR in Joomla! Issue Tracker, therefore, there is no way to mark the test result.
weird , it seems like that for the issue tracker this is an issue and not a pull request can confirm
there is NO Test this button
should we open a new issue on the issue tracker repo ?
maybe @brianteeman can redo the pr ;)
Fixed
I have tested this item
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/18372.
I have tested this item
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/18372.
| Status | Information Required | ⇒ | Ready to Commit |
Ready to Commit after two successful tests.
| Status | Ready to Commit | ⇒ | Fixed in Code Base |
| Closed_Date | 0000-00-00 00:00:00 | ⇒ | 2017-12-18 03:34:37 |
| Closed_By | ⇒ | mbabker | |
| Labels |
Added:
?
|
||
joomla-cms-bot
- | Category | Code style | ⇒ | Administration com_installer Code style |
Thanks
There isn't an entry for this PR in Joomla! Issue Tracker, therefore, there is no way to mark the test result.