? Pending

User tests: Successful: Unsuccessful:

avatar brianteeman
brianteeman
20 Oct 2017

The markup for the versions button was not consistent with the other toolbar buttons. aria-hidden=true was missing and an unnecessary title attribute was present.

avatar joomla-cms-bot joomla-cms-bot - change - 20 Oct 2017
Category Administration Templates (admin)
avatar brianteeman brianteeman - open - 20 Oct 2017
avatar brianteeman brianteeman - change - 20 Oct 2017
Status New Pending
avatar Quy
Quy - comment - 24 Oct 2017

Also this button does not have a div/class/id wrapper like the others.

For example: <div class="btn-wrapper" id="toolbar-cancel">

avatar brianteeman
brianteeman - comment - 24 Oct 2017

@Quy am i missing something

screenshotr09-18-52

avatar Quy Quy - test_item - 24 Oct 2017 - Tested successfully
avatar Quy
Quy - comment - 24 Oct 2017

I have tested this item successfully on 48e8ff2


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/18371.

avatar franz-wohlkoenig franz-wohlkoenig - test_item - 24 Oct 2017 - Tested successfully
avatar franz-wohlkoenig
franz-wohlkoenig - comment - 24 Oct 2017

I have tested this item successfully on 48e8ff2


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/18371.

avatar franz-wohlkoenig franz-wohlkoenig - change - 24 Oct 2017
Status Pending Ready to Commit
avatar franz-wohlkoenig
franz-wohlkoenig - comment - 24 Oct 2017

RTC after two successful tests.

avatar mbabker mbabker - change - 24 Oct 2017
Status Ready to Commit Fixed in Code Base
Closed_Date 0000-00-00 00:00:00 2017-10-24 21:26:02
Closed_By mbabker
Labels Added: ?
avatar mbabker mbabker - close - 24 Oct 2017
avatar mbabker mbabker - merge - 24 Oct 2017
avatar brianteeman
brianteeman - comment - 24 Oct 2017

Thanks

Add a Comment

Login with GitHub to post a comment