[#18326] - Protostar pagination update
- Fixed in Code Base
- 23 Oct 2017
- Medium
- Build: staging
- # 18326
- Diff
- brianteeman:protostar-pagination
User tests: Successful: Unsuccessful:
Improve thew accessibility of the pagination - there are no visual changes
- Wrap the pagination in a nav and add a role (needed for IE) and an aria-label
- Ensure font icons have aria-hidden=true
- Add aria-current to the selected page
- Add aria-title to the active links eg Go to page 1
Note 1
that the disabled links will not be announced to a screen reader which is the intended behaviour
Note 3
the list is an unordered list which appears to be the standard as otherwise the links would be announced as Link 1 go to page 2 etc which is nonsense
Note 4
I dont know why but protostar uses an override for pagination instead of the layout. For b/c this PR is just for the override but when approved I will do a similar PR for the layout
Thanks to @fuzzbomb (Drupal 8 Core Accessibility Maintainer) for his advice and reviewing this
joomla-cms-bot
- | Category | ⇒ | Administration Language & Strings Front End Templates (site) |
| Status | New | ⇒ | Pending |
| Labels |
Added:
?
?
|
||
I would prefer it to say Go to next page rather than Go to page Next. The same goes for Start, Prev, and End. Also should this change to use sprintf?
Looks good!
Go to prev page I understand why it is prev, but it would be nice to be previous.
Changing to previous will have to wait until this is approved and I can work n the pagination layout as well
I have tested this item
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/18326.
I'm seeing a lot of <a> elements without href which I think may be an issue for a11y in regards to tab indexing.
Could be wrong
It s perfectly ok because there is no link in there it is ignored. We checked that before submitting as we were not sure either
See the test report here https://gist.github.com/brianteeman/46e1cf36b6c57944c4b9c5efcad84c1d#gistcomment-2225785
I'm seeing a lot of elements without href which I think may be an issue for a11y in regards to tab indexing.
Just use href="javascript:void(0)"
There is no need
@brianteeman: Thanks to this work.
In my opinion, no additional nav tag is needed. Just replace the nav tag div in function pagination_list_footer. (This footer is part of navigation).
If you think you want to stay, as you proposed, let us know. Or correct.
And in one case and the other, I will test it successfully.
I'm seeing a lot of elements without href which I think may be an issue for a11y in regards to tab indexing.
It's OK.
I have tested this item
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/18326.
The nav tag is absolutely required.and i will not be removing it. Every accessibility source clearly says that this is a requirement. I am not surprised that the a11y team once again chose to do nothing and instead criticise those that actually contribute to making joomla more accessible
- I am sorry, but you misunderstood, of course, the nav tag is required. I have only proposed to include the whole element. Instead of div tag in function pagination_list_footer use nav tag:
function pagination_list_footer($list)
{
$html = "<nav role=\"navigation\" aria-label=\"' . JText::_('JLIB_HTML_PAGINATION') . '\" class=\"pagination\">\n";
$html .= $list['pageslinks'];
$html .= "\n<input type=\"hidden\" name=\"" . $list['prefix'] . "limitstart\" value=\"" . $list['limitstart'] . "\" />";
$html .= "\n</nav>";
return $html;
}-
It seems to me that directing, especially at my address, and not for the first time, the comments such as: " I am not surprised that the a11y team once again chose to do nothing and instead criticise those that actually contribute to making joomla more accessible" is at least out of place.
-
As I wrote earlier - if you leave the code unchanged, also I will test it successfully.
your code will break the templates i will not be changing it
| Status | Pending | ⇒ | Closed |
| Closed_Date | 0000-00-00 00:00:00 | ⇒ | 2017-10-22 23:23:21 |
| Closed_By | ⇒ | brianteeman |
| Status | Closed | ⇒ | New |
| Closed_Date | 2017-10-22 23:23:21 | ⇒ | |
| Closed_By | brianteeman | ⇒ |
| Status | New | ⇒ | Pending |
OK.
I have tested this item
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/18326.
| Status | Pending | ⇒ | Ready to Commit |
RTC after 3 successful tests.
mbabker
- | Status | Ready to Commit | ⇒ | Fixed in Code Base |
| Closed_Date | 0000-00-00 00:00:00 | ⇒ | 2017-10-23 23:26:11 |
| Closed_By | ⇒ | mbabker | |
| Labels |
Added:
?
|
||
Thanks
I have tested this item✅ successfully on 08d0638
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/18326.