[#18325] - fixed protected function calls in repeatable field
- Closed
- 21 Mar 2022
- Medium
- Build: staging
- # 18325
- Diff
- julienV:repeatable-fix
- Success hound No violations found. Woof! Details
- Pending continuous-integration/drone/pr this build is pending Details
- Success continuous-integration/travis-ci/pr The Travis CI build passed Details
- Success continuous-integration/appveyor/pr AppVeyor build succeeded Details
- Pending JTracker/HumanTestResults Human Test Results: 1 Successful 0 Failed. Details
User tests: Successful: Unsuccessful:
Pull Request for Issue # .
Summary of Changes
Replaced deprecated function calls in repeatable fields. It's deprecated, but can still be used by 3rd party.
Testing Instructions
display a form with a repeatable field
Expected result
it should work without throwing a fatal error...
Actual result
Documentation Changes Required
joomla-cms-bot
- | Category | ⇒ | Libraries |
| Status | New | ⇒ | Pending |
@Robbie8 Please mark your test result here: https://issues.joomla.org/tracker/joomla-cms/18325
I have tested this item
I tested this by accessing the Article Manager - to add a new article and edit an existing one.
Both tests completed as required
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/18325.
Reminder for @Robbie8
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/18325.
| Title |
|
||||||
I have tested this item
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/18325.
| Labels |
Added:
?
?
Removed: J3 Issue ? |
||
The functions "getLabel" and "getInput" are not deprecated. And can you post a link to the code where a fatal error is thrown? I can't think of a place where a deprecated message throws a fatal error.
I had a second look and indeed, these functions are protected. So we have to change to the properties or better to use the functions from the form instance.
Hi, sorry guys, but this is 5 (!!) years old, i have moved on, and i really don't have the time to setup everything for this...
| Status | Pending | ⇒ | Closed |
| Closed_Date | 0000-00-00 00:00:00 | ⇒ | 2022-03-21 19:58:05 |
| Closed_By | ⇒ | laoneo | |
| Labels |
Added:
Information Required
Removed: ? |
||
The Joomla support issue https://forum.joomla.org/viewtopic.php?f=706&t=955602&p=3498001#p3498001 gives more information on how the problem was identified