? ? Pending

User tests: Successful: Unsuccessful:

avatar ciar4n
ciar4n
8 Oct 2017

Pull Request for Issue # .

Summary of Changes

Creates LESS breakpoint variables for media queries within the admin template.

Testing Instructions

Code review of the template.css and template-rtl.css should be sufficient where only slightly varied media query widths should exist.

Expected result

Actual result

Documentation Changes Required

avatar joomla-cms-bot joomla-cms-bot - change - 8 Oct 2017
Category Administration Templates (admin)
avatar ciar4n ciar4n - open - 8 Oct 2017
avatar ciar4n ciar4n - change - 8 Oct 2017
Status New Pending
avatar ciar4n ciar4n - change - 8 Oct 2017
The description was changed
avatar ciar4n ciar4n - edited - 8 Oct 2017
avatar C-Lodder
C-Lodder - comment - 8 Oct 2017

Slight issue with these breakpoints. You cannot define @md as 768px, then do:

@media (min-width: @md) and @media (max-width: @md)

Need to be changed to something like:

@xs: 320px;
@sm: 480px;
@md: 768px;
@lg: 979px;
@xl: 1200px;

@sm-max: @sm - 1;
@md-max: @md - 1;
@lg-max: @lg - 1;
@xl-max: @xl - 1;

Then when doing the media queries:

@media (min-width: @md-max)
@media (max-width: @md)
avatar ciar4n
ciar4n - comment - 8 Oct 2017

Yea that crossed my mind. My understanding is that they would simply cascade and the second rule would apply if a screen width was exactly on a breakpoint.

As we have a pretty random order of min/max width media queries, it makes more sense to do as you suggest.

I'll sort this out later.

avatar ciar4n ciar4n - change - 8 Oct 2017
Labels Added: ?
avatar ciar4n
ciar4n - comment - 8 Oct 2017

Sorted now... thx Charlie

avatar Quy Quy - test_item - 13 Oct 2017 - Tested successfully
avatar Quy
Quy - comment - 13 Oct 2017

I have tested this item successfully on 4ae5b18


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/18276.

avatar csthomas
csthomas - comment - 20 Oct 2017

I do not have an experience, but why?
@lg: 979px;
I would expect:
@lg: 980px;

It is related to current changes:

-@media (max-width: 979px) {
+@media (max-width: 978px) {
avatar ciar4n
ciar4n - comment - 20 Oct 2017

In most cases the variables match the already existing values. I believe the 979px value comes from the bootstrap original breakpoint.. https://github.com/joomla/joomla-cms/blob/staging/media/jui/less/variables.less#L179

avatar franz-wohlkoenig
franz-wohlkoenig - comment - 26 Oct 2017

@csthomas can you please test so we get the second Test?


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/18276.

avatar csthomas
csthomas - comment - 26 Oct 2017

I did code review and I see one problem:

-@media (max-width: 979px) {
+@media (max-width: 978px) {

IMO this changes in a few lines is wrong and should be reverted. max-width should be 979px.
and variable @lg should be set to: 980px;

I talked with Charlie about it, I think he should agree with me but he has not answered yet to my last question.
@C-Lodder Could you confirm?

avatar C-Lodder
C-Lodder - comment - 26 Oct 2017

ah yes that's correct.

@lg should be 980px so that we match up with the BS2 grid:


/* Large desktop */
 @media (min-width: 1200px) { ... }
  
 /* Portrait tablet to landscape and desktop */
 @media (min-width: 768px) and (max-width: 979px) { ... }
  
 /* Landscape phone to portrait tablet */
 @media (max-width: 767px) { ... }
  
 /* Landscape phones and down */
 @media (max-width: 480px) { ... }
avatar csthomas csthomas - test_item - 26 Oct 2017 - Tested successfully
avatar csthomas
csthomas - comment - 26 Oct 2017

I have tested this item successfully on 6342355


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/18276.

avatar franz-wohlkoenig
franz-wohlkoenig - comment - 26 Oct 2017

@Quy can you please test again?

avatar Quy Quy - test_item - 3 Nov 2017 - Tested successfully
avatar Quy
Quy - comment - 3 Nov 2017

I have tested this item successfully on 6342355


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/18276.

avatar franz-wohlkoenig franz-wohlkoenig - change - 3 Nov 2017
Status Pending Ready to Commit
avatar franz-wohlkoenig
franz-wohlkoenig - comment - 3 Nov 2017

RTC after two successful tests.

avatar mbabker
mbabker - comment - 18 Nov 2017

Apparently merging another PR caused this to conflict...

avatar mbabker mbabker - change - 19 Nov 2017
Labels Added: ?
avatar mbabker mbabker - change - 19 Nov 2017
Status Ready to Commit Fixed in Code Base
Closed_Date 0000-00-00 00:00:00 2017-11-19 13:08:25
Closed_By mbabker
avatar mbabker mbabker - close - 19 Nov 2017
avatar mbabker mbabker - merge - 19 Nov 2017

Add a Comment

Login with GitHub to post a comment