User tests: Successful: Unsuccessful:
It should be possible to login using the keyboard only by using the tab key to move between fields. It works fine until you have a language select as thiis doesnt have a tabindex. As a result you have to tab past the login button to reach the language select. In addition if you have the tfa option enabled then the tfa option and the login button have the same tabindex. This PR resolves this - see animations
Category | ⇒ | Modules Administration |
Status | New | ⇒ | Pending |
Title |
|
Category | Modules Administration | ⇒ | Accessibility Administration Modules |
Done
I have tested this item
@brianteeman is there a particular reason that you're hardcoding the tab index instead of setting it to 0 (auto)?
Re: https://developer.mozilla.org/en-US/docs/Web/HTML/Global_attributes/tabindex
I was following the existing code which I assumed was there for a reason
I have tested this item
Set the tabindex for all elements = 0.
If the tabindex > 0, the tab order is incorrect.
Correct tab order: Username, the tip for Username, Password, the tip for Password, etc.
Incorrect tab order: Username, Password, Language, Login, the tip for Username, the tip for Password, etc.
In addition, in order to solve the problem of accessibility comprehensively, it would be necessary to add the missing legend tag for a fieldset tag (<legend>Form login</legend>
).
@dgt41 I remember now why it doesnt have tabindex=0 it is so that keyboard users do not have to tab past the useless tooltip. So it is one tab to move to the next field and not two.
@wojsmol This PR fixes the order of the tabs so that language is in the correct place. I prefer to contribute to joomla so that we see real improvements for our users today. I will remove the words a11y from the title and then you cannot say it is no good because it fixes a bug, If the a11y team ever start to work then they can contribute a fully accessible and usable fix - I would rather not wait
Title |
|
@brianteeman : I must admit that I completely do not understand your comment.
I will remove the words a11y from the title and then you cannot say it is no good because it fixes a bug.
No, unfortunately. Does not fix the error. On the contrary, it preserves it and creates the appearance that it is good.
4. If it's too difficult for you, I'll make the PR (I'm from the accessibility team, as you probably know). However, I thought that if you had already discovered this problem, it would not make it difficult for you to remove unnecessary tabindexes and possibly add one line of code with a new language sequence (legend).
However, I think you can do it yourself - I don't want to take away your authorship.
All tabindex attributes in this code need to be removed - they are unnecessary (so you don't need to set them to 0), because form controls automatically receive a focus according to the source ordering.
I have already explained
I have tested this item
Status | Pending | ⇒ | Ready to Commit |
RTC after two successful tests.
Status | Ready to Commit | ⇒ | Fixed in Code Base |
Closed_Date | 0000-00-00 00:00:00 | ⇒ | 2017-10-27 13:33:04 |
Closed_By | ⇒ | mbabker | |
Labels |
Added:
?
|
Thanks
Please add this PR to Accessibility category on issues.joomla.org.
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/18275.