? Pending

User tests: Successful: Unsuccessful:

avatar brianteeman
brianteeman
7 Oct 2017

It should be possible to login using the keyboard only by using the tab key to move between fields. It works fine until you have a language select as thiis doesnt have a tabindex. As a result you have to tab past the login button to reach the language select. In addition if you have the tfa option enabled then the tfa option and the login button have the same tabindex. This PR resolves this - see animations

Before

Before with language

before-lang

Before with TFA

before-tfa

Before with TFA and language

before-tfa-lang

After

After with language

after-lang

After with tfa

after-tfa

After with tfa and language

after-lang-tfa

avatar joomla-cms-bot joomla-cms-bot - change - 7 Oct 2017
Category Modules Administration
avatar brianteeman brianteeman - open - 7 Oct 2017
avatar brianteeman brianteeman - change - 7 Oct 2017
Status New Pending
avatar brianteeman brianteeman - change - 7 Oct 2017
Title
a11y admin login using keyboard
[a11y] admin login using keyboard
avatar brianteeman brianteeman - edited - 7 Oct 2017
avatar wojsmol
wojsmol - comment - 8 Oct 2017

Please add this PR to Accessibility category on issues.joomla.org.


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/18275.

avatar infograf768 infograf768 - change - 8 Oct 2017
Category Modules Administration Accessibility Administration Modules
avatar infograf768
infograf768 - comment - 8 Oct 2017

Done

avatar Quy Quy - test_item - 8 Oct 2017 - Tested successfully
avatar Quy
Quy - comment - 8 Oct 2017

I have tested this item successfully on 93a9ed7


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/18275.

avatar dgt41
dgt41 - comment - 8 Oct 2017

@brianteeman is there a particular reason that you're hardcoding the tab index instead of setting it to 0 (auto)?

Re: https://developer.mozilla.org/en-US/docs/Web/HTML/Global_attributes/tabindex

avatar brianteeman
brianteeman - comment - 8 Oct 2017

I was following the existing code which I assumed was there for a reason

avatar zwiastunsw zwiastunsw - test_item - 8 Oct 2017 - Tested unsuccessfully
avatar zwiastunsw
zwiastunsw - comment - 8 Oct 2017

I have tested this item ? unsuccessfully on 93a9ed7

Set the tabindex for all elements = 0.
If the tabindex > 0, the tab order is incorrect.
Correct tab order: Username, the tip for Username, Password, the tip for Password, etc.
Incorrect tab order: Username, Password, Language, Login, the tip for Username, the tip for Password, etc.


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/18275.

avatar zwiastunsw
zwiastunsw - comment - 8 Oct 2017

In addition, in order to solve the problem of accessibility comprehensively, it would be necessary to add the missing legend tag for a fieldset tag (<legend>Form login</legend>).

avatar brianteeman
brianteeman - comment - 8 Oct 2017

@dgt41 I remember now why it doesnt have tabindex=0 it is so that keyboard users do not have to tab past the useless tooltip. So it is one tab to move to the next field and not two.

@wojsmol This PR fixes the order of the tabs so that language is in the correct place. I prefer to contribute to joomla so that we see real improvements for our users today. I will remove the words a11y from the title and then you cannot say it is no good because it fixes a bug, If the a11y team ever start to work then they can contribute a fully accessible and usable fix - I would rather not wait

avatar brianteeman brianteeman - change - 8 Oct 2017
Title
[a11y] admin login using keyboard
admin login using keyboard fix tab order
avatar brianteeman brianteeman - edited - 8 Oct 2017
avatar zwiastunsw
zwiastunsw - comment - 9 Oct 2017

@brianteeman : I must admit that I completely do not understand your comment.

  1. You have marked your PR with the a11y label, not @wojsmol. @wojsmol only asked for a label to be added to Tracker Issue. Has he behaved improperly? I do not think so.
  2. If the code doesn't really have tabindex=0 so that keyboard users don't have to put it into useless toltips, then this explanation shows the foolishness of what they did. And sooner this stupidity needs to be repaired.
  1. You wrote that:

I will remove the words a11y from the title and then you cannot say it is no good because it fixes a bug.

No, unfortunately. Does not fix the error. On the contrary, it preserves it and creates the appearance that it is good.
4. If it's too difficult for you, I'll make the PR (I'm from the accessibility team, as you probably know). However, I thought that if you had already discovered this problem, it would not make it difficult for you to remove unnecessary tabindexes and possibly add one line of code with a new language sequence (legend).
However, I think you can do it yourself - I don't want to take away your authorship.
All tabindex attributes in this code need to be removed - they are unnecessary (so you don't need to set them to 0), because form controls automatically receive a focus according to the source ordering.

avatar brianteeman
brianteeman - comment - 9 Oct 2017

I have already explained

avatar franz-wohlkoenig franz-wohlkoenig - test_item - 26 Oct 2017 - Tested successfully
avatar franz-wohlkoenig
franz-wohlkoenig - comment - 26 Oct 2017

I have tested this item successfully on 93a9ed7


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/18275.

avatar franz-wohlkoenig franz-wohlkoenig - change - 26 Oct 2017
Status Pending Ready to Commit
avatar franz-wohlkoenig
franz-wohlkoenig - comment - 26 Oct 2017

RTC after two successful tests.

avatar mbabker mbabker - change - 27 Oct 2017
Status Ready to Commit Fixed in Code Base
Closed_Date 0000-00-00 00:00:00 2017-10-27 13:33:04
Closed_By mbabker
Labels Added: ?
avatar mbabker mbabker - close - 27 Oct 2017
avatar mbabker mbabker - merge - 27 Oct 2017
avatar brianteeman
brianteeman - comment - 27 Oct 2017

Thanks

Add a Comment

Login with GitHub to post a comment