? Pending

User tests: Successful: Unsuccessful:

avatar csthomas
csthomas
7 Oct 2017

Summary of Changes

Do not raise PHP Notice when build URL from invalid query.

Testing Instructions

  1. Install Joomla staging without sample data.
    • Search Engine Friendly URLs is enabled by default.
  2. Set Global Configuration -> Server -> Error Reporting to Maximum.
  3. Create one featured article with text:
<p><a href="index.php?option=com_content&amp;view=featured&amp;id=1">Broken link to featured view</a></p>
  1. Go to home page and check your error_log

Expected result

No PHP Notice

Actual result

PHP notice like:

Notice: Undefined index: id in .../components/com_content/helpers/legacyrouter.php on line 97
avatar joomla-cms-bot joomla-cms-bot - change - 7 Oct 2017
Category Front End com_content
avatar csthomas csthomas - open - 7 Oct 2017
avatar csthomas csthomas - change - 7 Oct 2017
Status New Pending
avatar ggppdk ggppdk - test_item - 7 Oct 2017 - Tested successfully
avatar ggppdk
ggppdk - comment - 7 Oct 2017

I have tested this item successfully on 0cb88f9


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/18271.

avatar Quy Quy - test_item - 7 Oct 2017 - Tested successfully
avatar Quy
Quy - comment - 7 Oct 2017

I have tested this item successfully on 0cb88f9


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/18271.

avatar franz-wohlkoenig franz-wohlkoenig - change - 8 Oct 2017
Status Pending Ready to Commit
avatar franz-wohlkoenig
franz-wohlkoenig - comment - 8 Oct 2017

RTC after two successful tests.

avatar wilsonge wilsonge - change - 9 Oct 2017
Status Ready to Commit Fixed in Code Base
Closed_Date 0000-00-00 00:00:00 2017-10-09 09:56:01
Closed_By wilsonge
Labels Added: ?
avatar wilsonge wilsonge - close - 9 Oct 2017
avatar wilsonge wilsonge - merge - 9 Oct 2017

Add a Comment

Login with GitHub to post a comment