User tests: Successful: Unsuccessful:
Pull Request for Issue #17956 .
add 4 flags in Jupdate object in order to save package name and to detect the cause of invalid extension update message
$this->noPhpMatch = true;
$this->noStabilityMatch = true;
$this->noDbMatch = true;
$this->packageName
in update function replace _JText('COM_INSTALLER_INVALID_EXTENSION_UPDATE') by messages explaining the possible cause(s) of the "invalid extension update"
in language file modify/add corresponding language strings
see https://issues.joomla.org/tracker/joomla-cms/17956
now, when upgrading an extension with insufficient PHP or Database or minimumm stability, the possible cause of the error is reported
none
In case of invalid extension update, the name of the package is given.
I supposed that one upgrade extension's manifest file only contains one package or one component. If several components or package (with different names) can be included in one manifest file the package name is no longer relevant.
Category | ⇒ | Administration com_installer Language & Strings Libraries |
Status | New | ⇒ | Pending |
Le 26/09/2017 23:08, zero-24 a écrit :
Hi @ChristopheSeg
Thanks fo your PR. Can you take a look into the errors thrown
by PHPCS http://ci.joomla.org/joomla/joomla-cms/25
?
Sorry I did not looked at coding standard: will modify this tomorrow
IMO when we start adding $this->no why not convert the other
variables containing the same information in that file too?
the JUpdate object ($this ) added parameter
$this->noStabilityMatch and the others do not carry the same
information as $StabilityMatch
$this->noStabilityMatch$this->noStabilityMatch and the other
—
You are receiving this because you were mentioned.
Reply to this email directly, view
it on GitHub, or mute
the thread.
{"api_version":"1.0","publisher":{"api_key":"05dde50f1d1a384dd78767c55493e4bb","name":"GitHub"},"entity":{"external_key":"github/joomla/joomla-cms","title":"joomla/joomla-cms","subtitle":"GitHub repository","main_image_url":"https://cloud.githubusercontent.com/assets/143418/17495839/a5054eac-5d88-11e6-95fc-7290892c7bb5.png","avatar_image_url":"https://cloud.githubusercontent.com/assets/143418/15842166/7c72db34-2c0b-11e6-9aed-b52498112777.png","action":{"name":"Open in GitHub","url":"https://github.com/joomla/joomla-cms"}},"updates":{"snippets":[{"icon":"PERSON","message":"@zero-24 in #18132: Hi @ChristopheSeg \r\n\r\nThanks fo your PR. Can you take a look into the errors thrown by PHPCS http://ci.joomla.org/joomla/joomla-cms/25 ?\r\n\r\nIMO when we start adding $this-\u003eno\u003cwhatever\u003e why not convert the other variables containing the same information in that file too?"}],"action":{"name":"View Pull Request","ur
l":"https://github.com/joomla/joomla-cms/pull/18132#issuecomment-332336846"}}}
Le 26/09/2017 23:08, zero-24 a écrit :
Hi @ChristopheSeg
Thanks fo your PR. Can you take a look into the errors thrown
by PHPCS http://ci.joomla.org/joomla/joomla-cms/25
?
Sorry I did not looked at coding standard: will modify this tomorrow
IMO when we start adding $this->no why not convert the other
variables containing the same information in that file too?
Just before the "invalid extension update" message is fired,
(before returning from "$update->get('downloadurl')->_data)"
the part of JUpdate object containing update information and name is
unset:
unset($this->latest);
unset($this->currentUpdate);
and the xml manifest files is closed
the JUpdate object ($this ) added parameter
($this->noStabilityMatch and the others) do not carry the same
information as $StabilityMatch
$StabilityMatch=true indicates that the current update (one among
all in the update manifest file) match stability. This variable is
calculated of each individual <update>...</update>
contained in the manifest file
$this->noStabilityMatch=true indicates that none of these file
match stability
—
You are receiving this because you were mentioned.
Reply to this email directly, view
it on GitHub, or mute
the thread.
{"api_version":"1.0","publisher":{"api_key":"05dde50f1d1a384dd78767c55493e4bb","name":"GitHub"},"entity":{"external_key":"github/joomla/joomla-cms","title":"joomla/joomla-cms","subtitle":"GitHub repository","main_image_url":"https://cloud.githubusercontent.com/assets/143418/17495839/a5054eac-5d88-11e6-95fc-7290892c7bb5.png","avatar_image_url":"https://cloud.githubusercontent.com/assets/143418/15842166/7c72db34-2c0b-11e6-9aed-b52498112777.png","action":{"name":"Open in GitHub","url":"https://github.com/joomla/joomla-cms"}},"updates":{"snippets":[{"icon":"PERSON","message":"@zero-24 in #18132: Hi @ChristopheSeg \r\n\r\nThanks fo your PR. Can you take a look into the errors thrown by PHPCS http://ci.joomla.org/joomla/joomla-cms/25 ?\r\n\r\nIMO when we start adding $this-\u003eno\u003cwhatever\u003e why not convert the other variables containing the same information in that file too?"}],"action":{"name":"View Pull Request","ur
l":"https://github.com/joomla/joomla-cms/pull/18132#issuecomment-332336846"}}}
Labels |
Added:
?
?
|
Category | Administration com_installer Language & Strings Libraries | ⇒ | Administration com_installer Libraries |
Status | Pending | ⇒ | Closed |
Closed_Date | 0000-00-00 00:00:00 | ⇒ | 2021-08-08 20:08:54 |
Closed_By | ⇒ | zero-24 | |
Labels |
Added:
?
Language Change
Removed: ? ? |
Category | Administration com_installer Libraries | ⇒ | Administration com_installer Language & Strings Libraries |
Dear @ChristopheSeg
in preperation of the upcomming release of Joomla 3.10 we have used GitHubs rename feature to rename the staging branch into 3.10-dev. Usually GitHub moves all existing PRs towards the new branch just fine, but here it didnt work. The reason seems to be that the fork of the CMS that was used as base for this PR has been deleted so GitHub does no longer have a base to rebase the PR against the new branch and we are also not able to reopen the PR. For that reason GitHub closed this PR in my name, when this issue is still valid It would require a new PR against the new 3.10-dev or 4.0-dev branch.
Hi @ChristopheSeg
Thanks fo your PR. Can you take a look into the errors thrown by PHPCS http://ci.joomla.org/joomla/joomla-cms/25 ?
IMO when we start adding $this->no why not convert the other variables containing the same information in that file too?