?

Pending

User tests: Successful: Unsuccessful:

avatar ggppdk
ggppdk
26 Sep 2017

Pull Request for Issue #18027

Summary of Changes

The issue was introduced by PR #17383 , that PR modified option->level to be option->level - 1

but option->level is later compared to zero to exclude checking ROOT category aka level 0 from ACL checks, thus all top level categories that had level 1 now have level 0 thus they are excluded from ACL checks

Testing Instructions

See issue #18027
For the publisher usergroup, open any top level category and deny "create"
Login as publisher and try to create new article

Expected result

The top category should not be shown in category selector

Actual result

The descendants category are correctly excuded (due to heritage), but the category itself is allowed to be selected

Documentation Changes Required

None

@mbabker , maybe v3.8.1 milestone,
this is easy to review, since it reverts the specific change that introduced the issue
(but also fixes the padding issue that PR #17383 was fixing in safer way)

avatar joomla-cms-bot joomla-cms-bot - change - 26 Sep 2017
Category Administration com_categories
avatar ggppdk ggppdk - open - 26 Sep 2017
avatar ggppdk ggppdk - change - 26 Sep 2017
Status New Pending
avatar ggppdk ggppdk - change - 26 Sep 2017
Title
Fix top-level category allowed to be selected for new records, despite disallowed via ACL core.create
Fix top-level category allowed to be selected for new / existing records, despite disallowed via ACL core.create
avatar ggppdk ggppdk - edited - 26 Sep 2017
avatar ggppdk ggppdk - change - 26 Sep 2017
The description was changed
avatar ggppdk ggppdk - edited - 26 Sep 2017
avatar ggppdk ggppdk - change - 26 Sep 2017
The description was changed
avatar ggppdk ggppdk - edited - 26 Sep 2017
avatar AlexRed AlexRed - test_item - 27 Sep 2017 - Tested successfully
avatar AlexRed
AlexRed - comment - 27 Sep 2017

I have tested this item successfully on b9871ba

Patch ok for me


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/18131.

avatar ggppdk ggppdk - change - 27 Sep 2017
The description was changed
avatar ggppdk ggppdk - edited - 27 Sep 2017
avatar franz-wohlkoenig franz-wohlkoenig - test_item - 29 Sep 2017 - Tested successfully
avatar franz-wohlkoenig
franz-wohlkoenig - comment - 29 Sep 2017

I have tested this item successfully on b9871ba


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/18131.

avatar franz-wohlkoenig franz-wohlkoenig - change - 29 Sep 2017
Status Pending Ready to Commit
avatar franz-wohlkoenig
franz-wohlkoenig - comment - 29 Sep 2017

RTC after two successful tests.

avatar mbabker mbabker - change - 30 Sep 2017
Status Ready to Commit Fixed in Code Base
Closed_Date 0000-00-00 00:00:00 2017-09-30 14:46:34
Closed_By mbabker
Labels Added: ?
avatar mbabker mbabker - close - 30 Sep 2017
avatar mbabker mbabker - merge - 30 Sep 2017
avatar ggppdk ggppdk - change - 30 Sep 2017
The description was changed
avatar ggppdk ggppdk - edited - 30 Sep 2017

Add a Comment

Login with GitHub to post a comment