Joomla! Issue Tracker - CMS

Download
Launch
Feeling Lucky

[#18038] - Fix flying focus minified version

? Pending

User tests: Successful: Unsuccessful:

avatar dneukirchen
dneukirchen
21 Sep 2017

Fix for:

Uncaught TypeError: Cannot read property 'style' of null
    at HTMLDocument.<anonymous> (flying-focus.min.js:1)

@dgt41

avatar joomla-cms-bot joomla-cms-bot - change - 21 Sep 2017
Category ⇒ JavaScript
avatar dneukirchen dneukirchen - open - 21 Sep 2017
avatar dneukirchen dneukirchen - change - 21 Sep 2017
Status New ⇒ Pending
avatar dneukirchen dneukirchen - change - 21 Sep 2017
The description was changed
avatar dneukirchen dneukirchen - edited - 21 Sep 2017
avatar C-Lodder
C-Lodder - comment - 21 Sep 2017

Can you please push the fix to my repo: https://github.com/C-Lodder/flying-focus

and I can then release an update

avatar dgt41
dgt41 - comment - 21 Sep 2017

@C-Lodder it's not the code from upstream, it's just a bug introduced due to merging conflicts
@wilsonge just merge this one

avatar C-Lodder
C-Lodder - comment - 21 Sep 2017

Fair enough. I'm switching to a new repo and will be pulling in the new package in a bit anyway.

avatar C-Lodder
C-Lodder - comment - 21 Sep 2017

PR with new package: #18048

avatar dneukirchen
dneukirchen - comment - 27 Sep 2017

We can close this one. I dont know what the plans for usage of flying focus are. Imo we can remove it. I dont see the big point in using it.

avatar dneukirchen dneukirchen - change - 27 Sep 2017
Status Pending ⇒ Closed
Closed_Date 0000-00-00 00:00:00 ⇒ 2017-09-27 18:49:11
Closed_By ⇒ dneukirchen
Labels Added: ?
avatar dneukirchen dneukirchen - close - 27 Sep 2017

Add a Comment

Login with GitHub to post a comment