[#18010] - Refactored ExceptionHandler
- Closed
- 23 Sep 2017
- Medium
- Build: staging
- # 18010
- Diff
- ethernidee:feature/ref-ex-handler
- Success hound No violations found. Woof! Details
User tests: Successful: Unsuccessful:
Summary of Changes
Refactored ExceptionHandler class (previously JErrorPage): separated logging and rendering, added helper methods, replaced old class names (JXxx) with namespaced ones.
Now if ExceptionHandler::render() is called manually from anywhere, no logging is performed. If ExceptionHandler::handleException() is called, both logging and rendering is performed.
Testing Instructions
Enter non-existing url in browser to trigger 404 page.
Expected result
Default template error page should be displayed, as usual.
Documentation Changes Required
No changes.
joomla-cms-bot
- | Category | ⇒ | Libraries |
| Status | New | ⇒ | Pending |
| Labels |
Added:
?
|
||
Closing pull request, cause drone is hanging.
| Status | Pending | ⇒ | Closed |
| Closed_Date | 0000-00-00 00:00:00 | ⇒ | 2017-09-23 15:51:16 |
| Closed_By | ⇒ | ethernidee |
@ethernidee Dron hanging can be solved without closing this PR.
I will try to open the new one. If issue remains, I will ask for help ))
Checked same git commands locally, everything worked. Tried to change commit a bit, but it also didn't help.
Is there any way to restart drone check? Have no clue, why the build failed.