User tests: Successful: Unsuccessful:
Category | ⇒ | Administration com_users |
Status | New | ⇒ | Pending |
It should be done like the Categories page where the text is wrapped in a <span class="element-invisible">
for accessiblity.
<span class="icon-publish hasTooltip" aria-hidden="true" title="Published items"><span class="element-invisible">Published items</span></span>
@pe7er any Opinion on @Quy's Comment above?
@pe7er the problem is that by doing that you left the code in a non accessible state. The change suggested by @Quy will resolve that. For reference see http://fontawesome.io/accessibility/
@brianteeman @Quy I don't understand what needs to be changed.
Could you please provide a patch. Thanks!
Tried to create a pull on your branch but it wouldnt let me ;( This is the code
<th width="1%" class="nowrap center">
<span class="icon-publish hasTooltip" aria-hidden="true" title="<?php echo JText::_('COM_USERS_COUNT_ENABLED_USERS'); ?>">
<span class="element-invisible"><?php echo JText::_('COM_USERS_COUNT_ENABLED_USERS'); ?></span>
</span>
</th>
<th width="1%" class="nowrap center">
<span class="icon-unpublish hasTooltip" aria-hidden="true" title="<?php echo JText::_('COM_USERS_COUNT_DISABLED_USERS'); ?>">
<span class="element-invisible"><?php echo JText::_('COM_USERS_COUNT_DISABLED_USERS'); ?></span>
</span>
</th>
I have tested this item
Hi, tested successfully.
I agree with Brian, element is needed.
Status | Pending | ⇒ | Ready to Commit |
Ready to Commit after two successful tests.
Please remove the RTC it needs to be updated with the code I suggested
Status | Ready to Commit | ⇒ | Pending |
Status set back on "Pending" as stated above.
Closed_By | Quy | ⇒ | joomla-cms-bot |
Status | Pending | ⇒ | Closed |
Closed_Date | 0000-00-00 00:00:00 | ⇒ | 2018-05-02 03:22:41 |
Closed_By | ⇒ | Quy |
Set to "closed" on behalf of @Quy by The JTracker Application at issues.joomla.org/joomla-cms/17924
Closing in favor for #20279.
I have tested this item✅ successfully on ee17910
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/17924.