Pending

User tests: Successful: Unsuccessful:

avatar pe7er
pe7er
10 Sep 2017

New PR to replace #12086 "User Groups - removed label: enabled/disabled users"
See #12086 for description.

In this new PR I just removed the "enabled users" and "disabled users" label, and only kept the icon.
Should work on mobile too now.

avatar joomla-cms-bot joomla-cms-bot - change - 10 Sep 2017
Category Administration com_users
avatar pe7er pe7er - open - 10 Sep 2017
avatar pe7er pe7er - change - 10 Sep 2017
Status New Pending
avatar franz-wohlkoenig franz-wohlkoenig - test_item - 10 Sep 2017 - Tested successfully
avatar franz-wohlkoenig
franz-wohlkoenig - comment - 10 Sep 2017

I have tested this item successfully on ee17910


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/17924.

avatar Quy
Quy - comment - 16 Sep 2017

It should be done like the Categories page where the text is wrapped in a <span class="element-invisible"> for accessiblity.

<span class="icon-publish hasTooltip" aria-hidden="true" title="Published items"><span class="element-invisible">Published items</span></span>

avatar franz-wohlkoenig
franz-wohlkoenig - comment - 26 Oct 2017

@pe7er any Opinion on @Quy's Comment above?


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/17924.

avatar pe7er
pe7er - comment - 26 Oct 2017

@Quy Sorry, I do not understand your remark.
I just removed 2 labels with span tags around them.

avatar brianteeman
brianteeman - comment - 26 Oct 2017

@pe7er the problem is that by doing that you left the code in a non accessible state. The change suggested by @Quy will resolve that. For reference see http://fontawesome.io/accessibility/

avatar pe7er
pe7er - comment - 26 Oct 2017

@brianteeman @Quy I don't understand what needs to be changed.
Could you please provide a patch. Thanks!

avatar brianteeman
brianteeman - comment - 26 Oct 2017

Tried to create a pull on your branch but it wouldnt let me ;( This is the code


						<th width="1%" class="nowrap center">
							<span class="icon-publish hasTooltip" aria-hidden="true" title="<?php echo JText::_('COM_USERS_COUNT_ENABLED_USERS'); ?>">
								<span class="element-invisible"><?php echo JText::_('COM_USERS_COUNT_ENABLED_USERS'); ?></span>
							</span>
						</th>
						<th width="1%" class="nowrap center">
							<span class="icon-unpublish hasTooltip" aria-hidden="true" title="<?php echo JText::_('COM_USERS_COUNT_DISABLED_USERS'); ?>">
								<span class="element-invisible"><?php echo JText::_('COM_USERS_COUNT_DISABLED_USERS'); ?></span>
							</span>
						</th>
avatar ladyjer ladyjer - test_item - 18 Nov 2017 - Tested successfully
avatar ladyjer
ladyjer - comment - 18 Nov 2017

I have tested this item successfully on ee17910

Hi, tested successfully.
I agree with Brian, element is needed.


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/17924.

avatar franz-wohlkoenig franz-wohlkoenig - change - 18 Nov 2017
Status Pending Ready to Commit
avatar franz-wohlkoenig
franz-wohlkoenig - comment - 18 Nov 2017

Ready to Commit after two successful tests.

avatar brianteeman
brianteeman - comment - 18 Nov 2017

Please remove the RTC it needs to be updated with the code I suggested

avatar franz-wohlkoenig franz-wohlkoenig - change - 18 Nov 2017
Status Ready to Commit Pending
avatar franz-wohlkoenig
franz-wohlkoenig - comment - 18 Nov 2017

Status set back on "Pending" as stated above.


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/17924.

avatar brianteeman
brianteeman - comment - 22 Apr 2018

@pe7er will you be updating this or shall we close it

avatar joomla-cms-bot joomla-cms-bot - change - 2 May 2018
Closed_By Quy joomla-cms-bot
avatar joomla-cms-bot joomla-cms-bot - close - 2 May 2018
avatar Quy Quy - change - 2 May 2018
Status Pending Closed
Closed_Date 0000-00-00 00:00:00 2018-05-02 03:22:41
Closed_By Quy
avatar joomla-cms-bot
joomla-cms-bot - comment - 2 May 2018

Set to "closed" on behalf of @Quy by The JTracker Application at issues.joomla.org/joomla-cms/17924

avatar Quy
Quy - comment - 2 May 2018

Closing in favor for #20279.


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/17924.

Add a Comment

Login with GitHub to post a comment