[#17923] - [TemplateAdapter.php] Rewrote hardcoded SQL to query object
- Fixed in Code Base
- 26 Feb 2018
- Medium
- Build: staging
- # 17923
- Diff
- pe7er:sql-to-query-object2
- Pending hound Hound is busy reviewing changes... Details
User tests: Successful: Unsuccessful:
Rewrote 2 SQL queries to query object format.
This code replaces PR #12748 "JInstallerAdapterTemplate - rewrote hardcoded SQL to object"
joomla-cms-bot
- | Category | ⇒ | Libraries |
| Status | New | ⇒ | Pending |
@franz-wohlkoenig It looks similar like #17921 but it's a different file.
| Labels |
Added:
?
|
||
Changed
->where($db->qn('home') . ' = '1' ')
to
->where($db->qn('home') . ' = ' . $db->q('1'))
I have tested this item
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/17923.
install templates
any should be enough
I have tested this item
Installation of "Free Joomla 3.5 Template – jPeople" (http://www.freshjoomlatemplates.com/free-joomla-3-5-template-jpeople/) works.
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/17923.
| Status | Pending | ⇒ | Ready to Commit |
RTC after two successful tests.
Has some requested changes that should be implemented before merging.
| Labels |
Added:
?
?
|
||
I have tested this item
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/17923.
can someone remove the RTC, update requested status, and test
| Status | Ready to Commit | ⇒ | Pending |
thanks folks, just another one little effort, please test
I have tested this item
Uninstalling the template was successful.
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/17923.
| Status | Pending | ⇒ | Ready to Commit |
@brianteeman Please remove Updates Requested label. Thanks.
| Status | Ready to Commit | ⇒ | Fixed in Code Base |
| Closed_Date | 0000-00-00 00:00:00 | ⇒ | 2018-02-26 03:20:25 |
| Closed_By | ⇒ | mbabker | |
| Labels |
Removed:
?
|
||
@alikon are this PR and #17921 the same and on should be closed?