Joomla! Issue Tracker - CMS

Download
Launch
Feeling Lucky

[#17920] - [4.0] core webcomponents compiling support

? Pending

User tests: Successful: Unsuccessful:

avatar dgt41
dgt41
10 Sep 2017

Pull Request for Issue # .

Summary of Changes

  • Beef up grunt to allow transpiling ES6 to ES5
  • Implement field media
  • Accomodate changes in the custom-elements repo
  • Import polyfills directly in this repo (used to be imported from custom-elements)

OK, so what the heck is this all about?

Following the path of dropping all previous versions of PHP (<7.0), this PR is enabling the use of modern Javascript, AKA ES6, in the core. The usage of ES6 ATM is only possible through custom elements

Pros

  • Project moves nicely along the major shifts in the javascript community
  • Code is simpler and thus probably less bugy

Cons

  • Since IE11 is still alive, a transpiled ES5 script is needed
  • The workflow for patching a bug get's one more step, compiling the js, think along the lines of LESS and SCSS. So if for css that is acceptable, I really don't see the reason JS will be an exception

Testing Instructions

Apply the patch:

  • Edit an article, go to Images and Links tab and try inserting an image for intro and full page.

Expected result

Actual result

Documentation Changes Required

The creating a PR documentation needs to be updated.

PS Added one check in tabs-state.js to stop Firefox failing

avatar joomla-cms-bot joomla-cms-bot - change - 10 Sep 2017
Category ⇒ JavaScript Repository Administration com_config Templates (admin) Layout Libraries
avatar dgt41 dgt41 - open - 10 Sep 2017
avatar dgt41 dgt41 - change - 10 Sep 2017
Status New ⇒ Pending
avatar dgt41 dgt41 - change - 10 Sep 2017
Title
…
[4.0] core webcomponents compilation support
[4.0] core webcomponents compiling support
avatar dgt41 dgt41 - edited - 10 Sep 2017
cb4df8f 8 Oct 2017 avatar dgt41 init
avatar dgt41 dgt41 - change - 8 Oct 2017
Labels Added: ?
avatar dgt41 dgt41 - change - 8 Oct 2017
The description was changed
avatar dgt41 dgt41 - edited - 8 Oct 2017
avatar dgt41
dgt41 - comment - 8 Oct 2017

@wilsonge can you merge this one?
This PR brings the src code of the media field that we're using and already merged through the new media manager branch

avatar joomla-cms-bot joomla-cms-bot - change - 8 Oct 2017
Category JavaScript Repository Administration com_config Templates (admin) Layout Libraries ⇒ JavaScript Repository Administration Templates (admin) Layout Libraries
c36bd16 8 Oct 2017 avatar dgt41 nope
avatar dgt41 dgt41 - change - 8 Oct 2017
The description was changed
avatar dgt41 dgt41 - edited - 8 Oct 2017
avatar wilsonge wilsonge - change - 8 Oct 2017
Status Pending ⇒ Fixed in Code Base
Closed_Date 0000-00-00 00:00:00 ⇒ 2017-10-08 13:53:12
Closed_By ⇒ wilsonge
avatar wilsonge wilsonge - close - 8 Oct 2017
avatar wilsonge wilsonge - merge - 8 Oct 2017
avatar dgt41
dgt41 - comment - 8 Oct 2017

Thanks

Add a Comment

Login with GitHub to post a comment