Feeling Lucky
?
[#17911] - [4.0] Make custom elements csp strict
- Closed
- 10 Oct 2017
- Medium
- Build: 4.0-dev
- # 17911
- Diff
- dgt41:§4.0-dev-custom-elements-csp
User tests: Successful: Unsuccessful:
Pull Request for Issue # .
Summary of Changes
A change in the way we use styling for custom elements, from injected by the JS we are moving to inline css tags generated in the back end.
So the only actual change here is removing the js code that injected the inline css and restructuring the folder so no it looks like:
---webcomponents
-----js
-------some-component.min.js
-----css
-------some-component.min.css
Testing Instructions
Apply patch edit/save an article. Alert appears normally
Expected result
Actual result
Documentation Changes Required
The change will be documented in the other repo (joomla-projects/custom-elements)
joomla-cms-bot
- | Category | ⇒ | Administration Templates (admin) Libraries JavaScript Front End Templates (site) |
| Status | New | ⇒ | Pending |
dgt41
- comment
- 10 Oct 2017
// Add the css if exists
HTMLHelper::_('stylesheet', str_replace('.js', '.css', $value), $options);I guess this covers the css-js splitting
| Status | Pending | ⇒ | Closed |
| Closed_Date | 0000-00-00 00:00:00 | ⇒ | 2017-10-10 09:02:23 |
| Closed_By | ⇒ | dgt41 | |
| Labels |
Added:
?
|
||
Is this now merged with what we did yesterday? Or does it need more work?