User tests: Successful: Unsuccessful:
Pull Request for Issue # .
This PR moves the menu script from the template to the respected module (mod_menu) and adds the dropdown script for the status module (mod_status, on the top right corner).
Both scripts are custom elements!!!
So now the dashboard is the first page in the administrator area the implements fully custom elements!
Well there is a reduction in the scripts size over 250% which of course results to an exactly same amount of reduction in the parse time and execution time of the browser!!! Do the math...
And here's the proof:
Joomla 3.7.5, total scripts size: 148.791Kb
Joomla 4.0 pre-alpha, total scripts size: 57.24Kb
Apply patch, menu and top right links (user & bell icon) still functioning as before
Category | ⇒ | Modules Administration Templates (admin) JavaScript |
Status | New | ⇒ | Pending |
i like that (250%) number
i hope to see "shortly" same number from frontend too
Nearly there. Basic functionality is working fine, however navigating via a keyboard seems a bit broken.
Compare against the 4.0-dev branch and you'll see what I mean
@C-Lodder most probably is coming from wrong context (the keyboard listening functions is bound to the wrong element). Should be easy to fix.
There is is bigger issue that needs to be solved here: the workflow for web components/custom elements that are not part of the other repo, do we:
If you need to put raw undistributed resources into this repo use the build
folder, that already has a plethora of stuff.
@dgt41 - I'd say lets put them in the other repo but in src/joomla
. We can then continue to work on them as normal. Then beef up grunt a little and use the following paths when pulling them in:
official components
media/vendor/webcomponents/xxx
components for Joomla
media/system/js/webcomponents/xxx
thoughts?
@C-Lodder importing all scripts has a huge negative in the PR workflow, someone needs to clone Joomla repo and the custom element repo. Do the work in the ce repo and copy paste to the actual Joomla folder to test. The basic UI components its ok to be another repo, but fields and components/modules/plugins need to stay in the same repo for easier bug fixing/code improvements. TBH I'm doing that for some time and it's way too hard.
media/system/js/webcomponents/xxx
That also cannot be good option for few reasons:
media/system/webcomponents/xxx
, Note there is no js
folder involvedI think build/webcomponents
is a good option in conjunction with the beefed up grunt (or shall we go to gulp or even web pack? Although such a move is a pretty big task on it's own)
I have tested this item
Here are the sizes before and after applying the patch
Page | Before Chrome / FireFox | After Chrome / FireFox
Control Panel | 219KB / 229.15KB | 62.3KB / 72.98KB
Article list | 200KB / 209.36KB | 200KB / 208.81KB
Category list | 241KB / 249.72KB | 241KB / 249.17KB
User list | 231KB / 239.96KB | 231KB / 239.41KB
Extension Man | 200KB / 209.36KB | 200KB / 208.81KB
So there is a huge gain on the control panel, other pages it has no effect but I think this is as expected but it would be great if the same can be done for other pages.
I have tested this item
Scripts are a lot smaller, yes! But the bell and user icon on the top right corner are not working anymore. Before the patch they showed their boxes. Now when I click on them, nothing happens :/
Windows Chrome v62.0.3202.62 and Firefox v56.0.1, testet on Joomla 4.0
I have tested this item
Scripts are a lot smaller, yes! But the bell and user icon on the top right corner are not working anymore. Before the patch they showed their boxes. Now when I click on them, nothing happens :/
Windows Chrome v62.0.3202.62 and Firefox v56.0.1, testet on Joomla 4.0
Status | Pending | ⇒ | Closed |
Closed_Date | 0000-00-00 00:00:00 | ⇒ | 2018-05-21 20:02:07 |
Closed_By | ⇒ | dgrammatiko | |
Labels |
Added:
?
|
Update checks arent even minified, so scripts size is even smaller :)