[#17809] - Clear button in article publish date
- Fixed in Code Base
- 17 Mar 2018
- Medium
- Build: staging
- # 17809
- Diff
- akritianand:staging
User tests: Successful: Unsuccessful:
Pull Request for Issue #17744.
Summary of Changes
Previously, when we edit an article under publishing tab, the clear button in calendar field did not work if it was a required field.
Now, it clears the calendar field when pressed instead of redirecting (as it did originally).
Changes were made in calendar.min.js
Testing Instructions
Create an admin form with a required date field. i.e. open administrator\components\com_content\models\forms\article.xml and make field "publish_down" required by adding required="true" to field's xml node.
Go to Joomla! administration panel and open an article edit view.
Finish Publishing field should now be a required field.
Add Finish Publishing date, using the date picker of the calendar
Click "Clear" button on the Calendar.
Expected result
Clears the field
Actual result
Redirects to Article Page
Documentation Changes Required
None
joomla-cms-bot
- | Category | ⇒ | JavaScript |
| Status | New | ⇒ | Pending |
Can you please include the changes in the non minified version? The minified is not reviewable and also it's just the minified version of calendar.js
| Labels |
Added:
?
|
||
@akritianand seems fine, thanks
@akritianand can you please look if #17744 is same PR?
@franz-wohlkoenig oh sorry, I think it's the same issue that I was solving. Can that previous patch be removed or closed in any way?
@akritianand sorry, meant #17793
@franz-wohlkoenig Yes, I meant the same.
@maintainers: Looks like PR #17793 and this are about same Issue - can you please decide how to handle this?
#17793 is closed
| Category | JavaScript | ⇒ | Administration com_modules JavaScript |
I have tested this item
Hit "Clear" on required Field as Example given above clears Field.
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/17809.
I have tested this item
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/17809.
| Status | Pending | ⇒ | Ready to Commit |
I will do a PR to delete the commented line after the merge if the OP does not do it beforehand.
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/17809.
| Labels |
Added:
?
|
||
| Status | Ready to Commit | ⇒ | Fixed in Code Base |
| Closed_Date | 0000-00-00 00:00:00 | ⇒ | 2018-03-17 15:10:17 |
| Closed_By | ⇒ | mbabker |
Sorry! I thought this is an issue (not PR): Deleted my comment