No Code Attached Yet Language Change J4 Issue
avatar CiverBlack
CiverBlack
30 Aug 2017

This issue aims to revert some of the changes made by @C-Lodder in #14613

I am proposing to reintroduce the "show/hide-HTML"-Button and the "All/Changed Values"-Button.

I agree that many of the information displayed in the 3.x version of this view aren´t often relevant to the users. But sometimes they are needed and some of them are crucial: If i use the "Read More"-Option on my site how i´m supposed to work with this view without the content os "Full text". I basically just see half my article. Also if i have a multilingual site i would like to see whats the "Language" of the article.

I don´t think anyone questions that people need to be able to see the HTML-Tags, but if i´m just concerned with the changes in the text of the article they tend to annoy, at least if you have many inline HTML-Tags like <strong>. Also we have to consider the Not-Programmer-User, they maybe don´t know HTML and are not able to understand what they are seeing.

Greetings,
Civer

@icampus

avatar CiverBlack CiverBlack - open - 30 Aug 2017
avatar joomla-cms-bot joomla-cms-bot - labeled - 30 Aug 2017
avatar brianteeman
brianteeman - comment - 30 Aug 2017

I have to agree with you - if i compare the two then for me at least the version compare in j3 is much easier to use

avatar C-Lodder
C-Lodder - comment - 30 Aug 2017

Sounds fair enough.

Would you mind submitting a PR?
This is the vendor package being used: https://github.com/kpdecker/jsdiff

avatar brianteeman
brianteeman - comment - 30 Aug 2017

if i remember correctly the reason for the change was because of the change in library?

avatar C-Lodder
C-Lodder - comment - 30 Aug 2017

Can't remember. Easily fixable though

avatar dgt41
dgt41 - comment - 30 Aug 2017

@CiverBlack can you take couple screenshots in j3 so we can visualise the changes you are referring here?

By the way there is no way to go back to the previous script as there are quite some maintainability problems with that (no uncompressed source code, no GitHub repo, the script is simply dead)

avatar C-Lodder
C-Lodder - comment - 30 Aug 2017

@dgt41 we don't need to go back to the old script.

Don't worry, I'll add this to my to-do list and get a PR submitted at some point

avatar brianteeman
brianteeman - comment - 30 Aug 2017

@C-Lodder maybe we can work on this at the sprint next weekend

avatar brianteeman
brianteeman - comment - 30 Aug 2017

@dgt41 they are like comparing apples and carrots

avatar C-Lodder
C-Lodder - comment - 30 Aug 2017

sounds good to me Brian

avatar CiverBlack
CiverBlack - comment - 31 Aug 2017

@dgt41 Here are the screenshots you wanted.

There are to many information displayed to get them all on my screen. So hear is a list of the entries which are displayed when show all is selected.

Field, Id, Title, Alias, Intro Text, Full text, Status, Category, Created Date, Created By, Created by Alias, Modified Date, Modified By, Start Publishing, Finish Publishing, Image Options, URL Options, Options, Ordering, Meta Keywords, Meta Description, Access, Hits, Metadata, Robots, Featured, Language, External Reference

I also just realized that it would help to be able to adjust the width of the 3 Rows.

HTML-Tags included and only the changed values:
bildschirmfoto 2017-08-31 um 14 04 33

HTML-Tags not included and with all values:
bildschirmfoto 2017-08-31 um 14 04 51

avatar dgt41
dgt41 - comment - 31 Aug 2017

@CiverBlack what is the output if you click on the Changed Values button?

avatar CiverBlack
CiverBlack - comment - 31 Aug 2017

@dgt41 you get only these columns where there is a change between the two versions.

avatar C-Lodder
C-Lodder - comment - 31 Aug 2017

It's basically just adding a button to hide/show the HTML tags within the changes.

avatar dgt41
dgt41 - comment - 31 Aug 2017

I am proposing to reintroduce the "show/hide-HTML"-Button and the "All/Changed Values"-Button.

@C-Lodder so that button exists?
Also didn't we discussed this and we decided to only show the things that actually have some changes or my memory fails me? If that was the case, honestly I'm against presenting the complete data, only the affected areas is the right approach from all point of views. As is this is very close to what GitHub has (or not?)

avatar C-Lodder
C-Lodder - comment - 31 Aug 2017

If it were down to me, I'd leave it as it is, cause it displays all changes, be it HTML or not.

But then again, not everybody works with a HTML editor , so may get very confused as what what the HTML tags are being displayed for, or what they even are.

avatar CiverBlack CiverBlack - change - 31 Aug 2017
The description was changed
avatar CiverBlack CiverBlack - edited - 31 Aug 2017
avatar franz-wohlkoenig franz-wohlkoenig - change - 1 Sep 2017
Status New Discussion
avatar brianteeman brianteeman - change - 25 Mar 2018
Labels Added: J4 Issue
avatar brianteeman brianteeman - labeled - 25 Mar 2018
avatar franz-wohlkoenig franz-wohlkoenig - change - 11 Apr 2019
Category Administration com_content com_contenthistory JavaScript Language & Strings Administration com_content com_contenthistory JavaScript
avatar franz-wohlkoenig franz-wohlkoenig - change - 11 Apr 2019
Labels Added: ?
avatar franz-wohlkoenig franz-wohlkoenig - labeled - 11 Apr 2019
avatar jwaisner jwaisner - change - 17 Apr 2020
Status Discussion Confirmed
avatar dgrammatiko
dgrammatiko - comment - 26 Jan 2022

This should be closed @richard67

avatar richard67 richard67 - change - 26 Jan 2022
Status Confirmed Closed
Closed_Date 0000-00-00 00:00:00 2022-01-26 19:57:50
Closed_By richard67
Labels Added: No Code Attached Yet Language Change
Removed: ? ?
avatar richard67 richard67 - close - 26 Jan 2022
avatar richard67
richard67 - comment - 26 Jan 2022

Closing for reasons stated above.

Add a Comment

Login with GitHub to post a comment