[#17720] - Perfomance issue for forms with large number of categories, fix 1000 queries generated by categoryedit when you have 500 categories (aka 2 queries per category)
- Fixed in Code Base
- 27 Aug 2017
- Medium
- Build: staging
- # 17720
- Diff
- ggppdk:patch-40
- Pending hound Hound is busy reviewing changes... Details
User tests: Successful: Unsuccessful:
Categoryedit field is quering the #__categories table, 2 times per category
- because it has the query inside the loop that examines each category
Solution move query outside of the loop
[EDIT]
Better solution just remove the query completely, there is an other query to the categories table just above, we can use that one to retrieve each categories language
Testing Instructions
Open forms having categoryedit,
e.g. article form
the category selector appears as befoe
Expected result
a single query is done to categories table by categoryedit field,
to get the language of categories that appear in the category selector
Actual result
multiple queries are done: 1 query is done per category
- and because when using fields the categoryedit is created twice
you get 2 queries per category
e.g. 500 categories you get 1000 queries
e.g. 5000 categories you get 10000 queries
Documentation Changes Required
none
joomla-cms-bot
- | Category | ⇒ | Administration com_categories |
| Status | New | ⇒ | Pending |
| Labels |
Added:
?
|
||
It is morning now, i was making coffee and realized there is another query to the categories table just above,
so we can just remove the query completely
coffee always win
I have tested this item
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/17720.
| Title |
|
||||||
I have tested this item
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/17720.
| Status | Pending | ⇒ | Ready to Commit |
RTC after two successful tests.
J3.8.0 milestone ?
it is easy to review the changes too
mbabker
- | Status | Ready to Commit | ⇒ | Fixed in Code Base |
| Closed_Date | 0000-00-00 00:00:00 | ⇒ | 2017-08-27 16:09:53 |
| Closed_By | ⇒ | mbabker | |
| Labels |
Added:
?
|
||
Ok why the title is like 1000 / 500 ?, it is not to be a smarta**, it is because it is better than saying "categoryedit does not scale", more people will notice and understand the need for this PR
so please excuse me for using the title ...
lately i am trying to use Joomla article form (which uses categoryedit field)
and my browser froze with 300 categories and debug on ... i had to stop what i was working on and track down this ...