[#17653] - Redirect plugin
- Fixed in Code Base
- 23 Aug 2017
- Medium
- Build: staging
- # 17653
- Diff
- bembelimen:redirect-plugin
User tests: Successful: Unsuccessful:
Summary of Changes
This PR adds the functionality to exclude specific urls in the redirect extension. For example I got a lot of wordpress hacking attemps on my Joomla! page (wp-admin) which are polluting my database. Now it's possible to exclude this things
Testing Instructions
- Apply this patch
- Activate the redirect plugin
- In the plugin you can either define a term or an regular expression (check the checkbox) for the string to seach
- Call a page which does not exists
Examples:
normal term: abc
regular expression: [x]{2}
Expected result
your-domain.tld/abc => will not be saved in the database
your-domain.tld/xx => will not be saved in the database
your-domain.tld/x => will be saved in the database
your-domain.tld/yy => will be saved in the database
joomla-cms-bot
- | Category | ⇒ | Administration Language & Strings Front End Plugins |
| Status | New | ⇒ | Pending |
| Labels |
Added:
?
?
|
||
Thanks @brianteeman
I have tested this item
Tested successfully on 3.7.5. Very cool!
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/17653.
Will there not be a performance hit?
With thousands of thousands excludes there will be a performance hit, when there is a error thrown, yes
@bembelimen won't the same be true with a regex?
Yes, true for both
@brianteeman to make it clear: this checks will only be triggered, if Joomla! throws an error, not in the normal process.
I have tested this item
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/17653.
@chmst @Didldu-Florian can you please retest?
I have tested this item
Plugin works as described above.
Notes
I don't know if this is an intentional behaviour, but maybe the url preg_match should include the word boundary parameters, so it has to match the whole url. I was kind of confused '[x]{2}' also matches 'xxx' and 'xxasdasd'. Same applies for non-regex excludes.
Current
preg_match('/' . $exclude->term . '/i', $orgurlRel)
Suggestion
preg_match('/\b' . $exclude->term . '\b/i', $orgurlRel)
Tested @icampus
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/17653.
I have tested this item
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/17653.
| Status | Pending | ⇒ | Ready to Commit |
RTC after two successful tests.
Thanks Guys.
| Labels |
Added:
?
|
||
| Status | Ready to Commit | ⇒ | Fixed in Code Base |
| Closed_Date | 0000-00-00 00:00:00 | ⇒ | 2017-08-23 11:53:34 |
| Closed_By | ⇒ | mbabker |
The language strings that are for tooltips (***_DESC) should end with a period.
As far as I remember the *.sys.ini language file is only for items that will be added to a menu. Regular language strings should be in *.ini