Pull Request for Issue #17599

Summary of Changes

Changed libraries\src\Component\Router\Rules\MenuRules.php not to replace Itemid if Itemid is supplied in passed query.

Testing Instructions

J!3.7.5 - Search Engine Friendly URLs OFF.
Create some 'uncategorised' articles.
Create two menuitems in Main Menu of type 'Category List' (and for easier detection differentiate the second, showing Category Title) pointing to 'uncetegorised': 'Show-uncategorised-1' (Itemid=108) and 'Show-uncategorised-2' (Itemid=109)

Expected result

When user clicks each menu it goes to the right page and all the menuitems continue to work correctly.

Actual result

If you click 'Show-uncategorised-1' (lower Itemid) all is fine.

If you click 'Show-uncategorised-2' (higher Itemid) ti goes to the right page but the menu link generated in the new page for the menuitem with higher Itemid ('Show-uncategorised-2') is wrong: menu link generated for 'Show-uncategorised-2' now points to'index.php?option=com_content&view=category&id=2&Itemid=108'. That's obviously wrong, it should use Itemid?109).
So now if you click on 'Show-uncategorised-2' you actually go to 'Show-Category-1' !

System information (as much as possible)

J!3.7.5 - Search Engine Friendly URLs OFF.

Documentation Changes Required

none

Additional comments

The same problem arises with other menu types (tried with multiple Submit Article menuitems: same malfunctioning).

This problem is common to issue: ' Router incorrectly tries to "fix" Itemid #16774 '.

Everything works well if Search Engine Friendly URLs is ON.