User tests: Successful: Unsuccessful:
See issue #17579 - Managing extension packages
https://issues.joomla.org/tracker/joomla-cms/17579
Pull Request for Issue # .
Added -- Select Package -- list to search tool in extension manager
Added links to plugin / template edit in extension manager list display
Goto .../administrator/index.php?option=com_installer&view=manage
Go to Search Tools and Select a Package
Category | ⇒ | Administration com_installer |
Status | New | ⇒ | Pending |
Category | Administration com_installer | ⇒ | Administration com_installer Language & Strings |
Labels |
Added:
?
|
Labels |
Added:
?
|
@BrainforgeUK it looks like you have mix up tabs and spaces in the last commit again ;)
Hey! After applying your patch all I see is a blank input field in the search tools. Entering text data does nothing in it.
@BrainforgeUK i can confirm the result of @akritianand
Fixed - package field class file missing!
New file got left out of git by accident.
Be better to change the package field class in package.php into a standard form field.
i.e. move
from :
/administrator/components/com_installer/models/fields/package.php
to :
/libraries/joomla/form/fields/package.php
Can then add package as a plugins list search - it makes sense to distribute several plugins as a package.
administrator/index.php?option=com_plugins
Other people may find the same form field useful elsewhere.
Will implement above shortly!
Category | Administration com_installer Language & Strings | ⇒ | Administration com_installer Language & Strings Libraries |
Category | Administration com_installer Language & Strings Libraries | ⇒ | Administration com_installer com_plugins Language & Strings Libraries |
I have tested this item
I have tested this item
@BrainforgeUK nice addition! The functionality is working correctly, but some code style improvements are still needed (tabs & spaces) as commented by others before.
We seem to have got stuck with this.
Not in Joomla 4.0
How do we move on?
@BrainforgeUK Please fix coding style as mentioned previously. Use tabs (not spaces) to indent code.
Category | Administration com_installer Language & Strings Libraries com_plugins | ⇒ | Administration com_installer com_plugins Language & Strings Templates (admin) Libraries |
For your reference on coding style: https://developer.joomla.org/coding-standards/php-code.html
Can you rebase that branch for Joomla 4?
Category | Administration com_installer Language & Strings Libraries com_plugins Templates (admin) | ⇒ | Administration com_installer com_plugins Language & Strings Templates (admin) SQL Installation Libraries |
You have added completely unrelated code3 to this issue
You must use a different branch and create a different pull request for each issue you are trying to resolve
In your git client revert this latest change, commit and push
Then create a NEW branch and pull from staging
Make your new changes, commit and push
go to https://github.com/joomla/joomla-cms and you will see info that you can create a new pull request from your new branch
Category | Administration com_installer Language & Strings Libraries com_plugins Templates (admin) SQL Installation | ⇒ | Administration com_installer com_plugins Language & Strings Templates (admin) Libraries |
I have tested this item
Tested on J3.9 alpha
works for me as expected
Category | Administration com_installer Language & Strings Libraries com_plugins Templates (admin) | ⇒ | Unit Tests Repository Administration com_admin |
Closed_Date | 2019-05-15 12:11:54 | ⇒ | 2019-05-15 12:11:56 |
Closed_By | Quy | ⇒ | joomla-cms-bot |
Status | Pending | ⇒ | Closed |
Closed_Date | 0000-00-00 00:00:00 | ⇒ | 2019-05-15 12:11:54 |
Closed_By | ⇒ | Quy |
Set to "closed" on behalf of @Quy by The JTracker Application at issues.joomla.org/joomla-cms/17585
Please rebase for J4.
@BrainforgeUK Thanks for your PR. i have just fixed some minor code style issues. I hope i get some time to test this feature too. If you have any questions about the changes I made please feel free to ask me.