J3 Issue ? ? Failure

User tests: Successful: Unsuccessful:

avatar BrainforgeUK
BrainforgeUK
17 Aug 2017

See issue #17579 - Managing extension packages
https://issues.joomla.org/tracker/joomla-cms/17579

Pull Request for Issue # .

Summary of Changes

Added -- Select Package -- list to search tool in extension manager
Added links to plugin / template edit in extension manager list display

Testing Instructions

Goto .../administrator/index.php?option=com_installer&view=manage
Go to Search Tools and Select a Package

Expected result

Actual result

Documentation Changes Required

avatar joomla-cms-bot joomla-cms-bot - change - 17 Aug 2017
Category Administration com_installer
avatar brainforgeUK brainforgeUK - open - 17 Aug 2017
avatar brainforgeUK brainforgeUK - change - 17 Aug 2017
Status New Pending
avatar joomla-cms-bot joomla-cms-bot - change - 17 Aug 2017
Category Administration com_installer Administration com_installer Language & Strings
avatar brainforgeUK brainforgeUK - change - 17 Aug 2017
Labels Added: ?
avatar zero-24 zero-24 - change - 17 Aug 2017
Labels Added: ?
avatar zero-24
zero-24 - comment - 17 Aug 2017

@BrainforgeUK Thanks for your PR. i have just fixed some minor code style issues. I hope i get some time to test this feature too. If you have any questions about the changes I made please feel free to ask me.

avatar zero-24
zero-24 - comment - 17 Aug 2017

@BrainforgeUK it looks like you have mix up tabs and spaces in the last commit again ;)

avatar akritianand
akritianand - comment - 19 Aug 2017

Hey! After applying your patch all I see is a blank input field in the search tools. Entering text data does nothing in it.


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/17585.

avatar zero-24
zero-24 - comment - 19 Aug 2017

@BrainforgeUK i can confirm the result of @akritianand

To me it looks like this in the backend.
image

avatar BrainforgeUK
BrainforgeUK - comment - 19 Aug 2017

Fixed - package field class file missing!
New file got left out of git by accident.


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/17585.

avatar BrainforgeUK
BrainforgeUK - comment - 19 Aug 2017

Be better to change the package field class in package.php into a standard form field.
i.e. move
from :
/administrator/components/com_installer/models/fields/package.php
to :
/libraries/joomla/form/fields/package.php

Can then add package as a plugins list search - it makes sense to distribute several plugins as a package.
administrator/index.php?option=com_plugins
Other people may find the same form field useful elsewhere.

Will implement above shortly!

avatar joomla-cms-bot joomla-cms-bot - change - 19 Aug 2017
Category Administration com_installer Language & Strings Administration com_installer Language & Strings Libraries
avatar joomla-cms-bot joomla-cms-bot - change - 19 Aug 2017
Category Administration com_installer Language & Strings Libraries Administration com_installer com_plugins Language & Strings Libraries
avatar Heggi93 Heggi93 - test_item - 22 Aug 2017 - Tested successfully
avatar Heggi93
Heggi93 - comment - 22 Aug 2017

I have tested this item successfully on acb7121


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/17585.

avatar sanderpotjer sanderpotjer - test_item - 31 Aug 2017 - Tested unsuccessfully
avatar sanderpotjer
sanderpotjer - comment - 31 Aug 2017

I have tested this item ? unsuccessfully on acb7121

@BrainforgeUK nice addition! The functionality is working correctly, but some code style improvements are still needed (tabs & spaces) as commented by others before.


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/17585.

avatar BrainforgeUK
BrainforgeUK - comment - 1 Dec 2017

We seem to have got stuck with this.
Not in Joomla 4.0
How do we move on?

avatar Quy
Quy - comment - 3 Dec 2017

@BrainforgeUK Please fix coding style as mentioned previously. Use tabs (not spaces) to indent code.

avatar joomla-cms-bot joomla-cms-bot - change - 4 Dec 2017
Category Administration com_installer Language & Strings Libraries com_plugins Administration com_installer com_plugins Language & Strings Templates (admin) Libraries
avatar Quy
Quy - comment - 4 Dec 2017
avatar alikon
alikon - comment - 20 Mar 2018

can be a nice addition for 3.9 imo
after a quick test with one of mine very old package some feedback:
screenshot from 2018-03-20 19-44-37

you should add the "linkable" features to modules too

avatar laoneo
laoneo - comment - 12 Apr 2018

Can you rebase that branch for Joomla 4?

avatar BrainforgeUK
BrainforgeUK - comment - 12 Apr 2018

Joomla 4 - I've tried to do a pull request like this.
#20152

I'm using PHPStorm, and tried rebasing to Joomla 4 as suggested, but unsuccessful.

avatar joomla-cms-bot joomla-cms-bot - change - 20 Aug 2018
Category Administration com_installer Language & Strings Libraries com_plugins Templates (admin) Administration com_installer com_plugins Language & Strings Templates (admin) SQL Installation Libraries
avatar brianteeman
brianteeman - comment - 20 Aug 2018

You have added completely unrelated code3 to this issue

You must use a different branch and create a different pull request for each issue you are trying to resolve

In your git client revert this latest change, commit and push

Then create a NEW branch and pull from staging
Make your new changes, commit and push
go to https://github.com/joomla/joomla-cms and you will see info that you can create a new pull request from your new branch

avatar joomla-cms-bot joomla-cms-bot - change - 20 Aug 2018
Category Administration com_installer Language & Strings Libraries com_plugins Templates (admin) SQL Installation Administration com_installer com_plugins Language & Strings Templates (admin) Libraries
avatar ka3media
ka3media - comment - 8 Sep 2018

I have tested this item successfully on c611354

Tested on J3.9 alpha

works for me as expected


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/17585.

avatar ka3media ka3media - test_item - 8 Sep 2018 - Tested successfully
avatar joomla-cms-bot joomla-cms-bot - change - 22 Oct 2018
Category Administration com_installer Language & Strings Libraries com_plugins Templates (admin) Unit Tests Repository Administration com_admin
avatar joomla-cms-bot joomla-cms-bot - change - 15 May 2019
Closed_Date 2019-05-15 12:11:54 2019-05-15 12:11:56
Closed_By Quy joomla-cms-bot
avatar joomla-cms-bot joomla-cms-bot - close - 15 May 2019
avatar Quy Quy - change - 15 May 2019
Status Pending Closed
Closed_Date 0000-00-00 00:00:00 2019-05-15 12:11:54
Closed_By Quy
avatar joomla-cms-bot
joomla-cms-bot - comment - 15 May 2019

Set to "closed" on behalf of @Quy by The JTracker Application at issues.joomla.org/joomla-cms/17585

avatar Quy
Quy - comment - 15 May 2019

Please rebase for J4.


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/17585.

Add a Comment

Login with GitHub to post a comment