[#17584] - Rename form fields to lowercase
- Fixed in Code Base
- 22 Aug 2017
- Medium
- Build: staging
- # 17584
- Diff
- Digital-Peak:form/fields/lowercase
- Pending hound Hound is busy reviewing changes... Details
User tests: Successful: Unsuccessful:
Pull Request for Issue #17460.
Summary of Changes
Because of autoloading the class names and their corresponding files must match the scheme first character uppercase then all lowercase and Field as suffix. This pr changes the core fields to that.
Testing Instructions
- Log in on the back end
- Go to Users -> Manage
- Click on the "Search Tools" button
Expected result
Proper select boxes do appear.
Actual result
Only input text fields are shown.
joomla-cms-bot
- | Category | ⇒ | Libraries |
| Status | New | ⇒ | Pending |
Guess you need to update your staging branch.
| Labels |
Added:
?
|
||
the test was made with the current staging (at the test time), i'll redo the test ex-novo without patchtester
I'v also merged staging int this branch. So now it should be even.
thanks and sorry for the extra work
I have tested this item
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/17584.
The issue of this pr had a release blocker label, should this pr then also get it?
I have tested this item
I went to the Users -> Manage and i didn't get the problem you described. After that i installed the patch via patch tester and nothing changed. I was also unable to revert the patch via patch tester so something went wrong there but i couldn't find out what.
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/17584.
I'm not sure if the problem is because of the different file names. Please install joomla from here https://github.com/Digital-Peak/joomla-cms/archive/form/fields/lowercase.zip and test it again.
I have tested this item
Yes now it works
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/17584.
Thanks for testing!
| Status | Pending | ⇒ | Ready to Commit |
RTC after two successful tests.
mbabker
- | Status | Ready to Commit | ⇒ | Fixed in Code Base |
| Closed_Date | 0000-00-00 00:00:00 | ⇒ | 2017-08-22 11:35:57 |
| Closed_By | ⇒ | mbabker | |
| Labels |
Added:
?
|
||
this pr with com_patchtester
should be patched without com_patchtester?