[#17516] - Clean up core.js
- Fixed in Code Base
- 13 Aug 2017
- Medium
- Build: staging
- # 17516
- Diff
- dgt41:patch-1
User tests: Successful: Unsuccessful:
Pull Request for Issue # .
Summary of Changes
Core.js has some global functions and some really useless one. This PR adds deprecations so we can clean up the file in Joomla 4 (simple proxy).
The only code related change is:
- Function window.listItemTask is calling Joomla.listItemTask() which is the replacement (simple proxy). This was done in a few more places in this file...
Other than that some CS changes
Testing Instructions
Nothing breaks in the admin
Documentation Changes Required
Core will be fully documented in J4, as the rest of the javascript (hopefully we will get more people in javascript group at some point in the near future)
joomla-cms-bot
- | Category | ⇒ | JavaScript |
| Status | New | ⇒ | Pending |
| Labels |
Added:
?
|
||
I have tested this item
Test on List-Views as i suggest "Function window.listItemTask" is for this Views.
If not please explain what to test.
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/17516.
@franz-wohlkoenig yes the function is used in the list view, e.g. the publish/unpublish button(or the feature/unfeature) before the title in each row in the articles view.
Test (un)publish- and (un)feature-Button, works as well.
mbabker
- | Status | Pending | ⇒ | Fixed in Code Base |
| Closed_Date | 0000-00-00 00:00:00 | ⇒ | 2017-08-13 15:58:31 |
| Closed_By | ⇒ | mbabker |
@mbabker this one is for you :)