?
avatar twister65
twister65
10 Aug 2017

Steps to reproduce the issue

Update Joomla! 3.6.5 to 3.7.4 with a postgresql database.

Expected result

  • administrator/components/com_admin/sql/updates/postgresql/3.7.0-2016-11-21.sql
    ALTER TABLE "#__languages" DROP CONSTRAINT "#__languages_idx_image";

  • administrator/components/com_admin/sql/updates/postgresql/3.7.0-2016-11-19.sql
    ALTER TABLE "#__menu_types" ADD COLUMN "client_id" int DEFAULT 0 NOT NULL;

  • Execute manually administrator/components/com_admin/sql/updates/postgresql/3.7.0-2017-01-17.sql
    with the correct prefix of your tables.

Actual result

  • administrator/components/com_admin/sql/updates/postgresql/3.7.0-2016-11-21.sql
    ALTER TABLE "#__languages" DROP CONSTRAINT "#__idx_image";

  • administrator/components/com_admin/sql/updates/postgresql/3.7.0-2016-11-19.sql
    ALTER TABLE "#__menu_types" ADD "client_id" int DEFAULT 0 NOT NULL;

  • administrator/components/com_admin/sql/updates/postgresql/3.7.0-2017-01-17.sql doesn't execute during the update process.

System information (as much as possible)

Additional comments

avatar twister65 twister65 - open - 10 Aug 2017
avatar joomla-cms-bot joomla-cms-bot - labeled - 10 Aug 2017
avatar franz-wohlkoenig franz-wohlkoenig - change - 10 Aug 2017
Priority Critical Medium
avatar alikon
alikon - comment - 12 Aug 2017

this pr #17499 fix the issues described here
i've found just one more upgrading fixed with #17505

avatar franz-wohlkoenig franz-wohlkoenig - change - 12 Aug 2017
Status New Closed
Closed_Date 0000-00-00 00:00:00 2017-08-12 09:46:07
Closed_By franz-wohlkoenig
avatar joomla-cms-bot joomla-cms-bot - change - 12 Aug 2017
Closed_Date 2017-08-12 09:46:07 2017-08-12 09:46:08
Closed_By franz-wohlkoenig joomla-cms-bot
avatar joomla-cms-bot joomla-cms-bot - close - 12 Aug 2017
avatar joomla-cms-bot
joomla-cms-bot - comment - 12 Aug 2017
avatar franz-wohlkoenig
franz-wohlkoenig - comment - 12 Aug 2017

closed as having Pull Request #17499


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/17473.

avatar twister65
twister65 - comment - 12 Aug 2017

administrator/components/com_admin/sql/updates/postgresql/3.7.0-2017-01-17.sql is not yet launched during the upgrade process. Therefore, you don't have the complete component menu in the administration panel.
You have to resolve this bug, before closing the issue.
Thanks.

avatar franz-wohlkoenig franz-wohlkoenig - change - 12 Aug 2017
Status Closed Discussion
Closed_Date 2017-08-12 09:46:08
Closed_By joomla-cms-bot
avatar joomla-cms-bot joomla-cms-bot - reopen - 12 Aug 2017
avatar franz-wohlkoenig
franz-wohlkoenig - comment - 12 Aug 2017

reopened as stated above.


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/17473.

avatar joomla-cms-bot
joomla-cms-bot - comment - 12 Aug 2017
avatar wojsmol
wojsmol - comment - 12 Aug 2017

@richard67 Please look at #17473 (comment)

avatar richard67
richard67 - comment - 13 Aug 2017

@twister65 What means "is not yet launched"? Does it mean the script is not executed because the update breaks with the SQL errors in the scripts being executed before it? Or does it mean the postgresql/3.7.0-2017-01-17.sql is being executed but fails because of errors in this script? You can easily find out by checking the SQL statements being logged in administrator/logs/joomla_update.php. And have you tested both PRs mentioned in @alikon 's comment above together?

@wojsmol Why do you ask me? Do you think the postgresql/3.7.0-2017-01-17.sql which I once had modified has an error?

avatar richard67
richard67 - comment - 13 Aug 2017

I just checked: The script postgresql/3.7.0-2017-01-17.sql fails if the column client_id in table #__menu_types does not exist yet. This is the case if the script postgresql/3.7.0-2016-11-19.sql has failed to run before. But with PR #17499 this should be fixed and both should run.

avatar richard67
richard67 - comment - 13 Aug 2017

With PR #17499 this is fixed and both do run, I just tested.

avatar richard67
richard67 - comment - 13 Aug 2017

@twister65 Or did you maybe expect the statements in 3.7.0-2017-01-17.sql to be run by the database fixer after a failed update? That will not be the case because the database fixer does not handle INSERT, UPDATE or DELETE statements, that's a known problem. So for a test you have to download a 3.7.4 update package, unzip it, exchange the files modified by PR #17499 by those from the PR, then zip it again and do the Joomla Update on the "Upload & Update" tab of the Joomla Update view. You will then find that there is another SQL error happening in a script after 3.7.0-2017-01-17.sql, see PR #17505 . But the 3.7.0-2017-01-17.sql will have executed in that test. In the same way you then can test PR #17505 .

avatar twister65
twister65 - comment - 13 Aug 2017

Your are right, Richard67, the tree of my archive file was incorrect.
I've tested it again with the PR #17505 and #17499, and It's working now.
Therefore, you can close this issue.
Regards.

avatar brianteeman
brianteeman - comment - 13 Aug 2017

Closed as requested

avatar brianteeman brianteeman - change - 13 Aug 2017
Status Discussion Closed
Closed_Date 0000-00-00 00:00:00 2017-08-13 11:31:07
Closed_By brianteeman
avatar brianteeman brianteeman - close - 13 Aug 2017
avatar richard67
richard67 - comment - 13 Aug 2017

@twister65 If you have tested with PR #17505 , could you set the test result to success using the "test this" button in the issue tracker https://issues.joomla.org/tracker/joomla-cms/17505 ?

@alikon Do you think you find time to you test @twister65 ' s PR #17499 ?


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/17473.

avatar wojsmol
wojsmol - comment - 13 Aug 2017

@richard67 Thanks for checking this ?

Add a Comment

Login with GitHub to post a comment