? ? Pending

User tests: Successful: Unsuccessful:

avatar kavadas
kavadas
10 Aug 2017

Pull Request for Issue #17449

avatar joomla-cms-bot joomla-cms-bot - change - 10 Aug 2017
Category Modules Front End
avatar kavadas kavadas - open - 10 Aug 2017
avatar kavadas kavadas - change - 10 Aug 2017
Status New Pending
avatar franz-wohlkoenig franz-wohlkoenig - test_item - 10 Aug 2017 - Tested successfully
avatar franz-wohlkoenig
franz-wohlkoenig - comment - 10 Aug 2017

I have tested this item successfully on 9d77b88

"No Images" is shown.


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/17472.

avatar franz-wohlkoenig franz-wohlkoenig - change - 10 Aug 2017
Easy No Yes
avatar brianteeman
brianteeman - comment - 10 Aug 2017

While this is correct I wonder why we didn't have the problem before

avatar kavadas
kavadas - comment - 10 Aug 2017

@brianteeman Because in 3.x the main module file ( mod_random_image.php ) had a check for empty images array. In 4.0 this check is moved inside the layout file:

73c0563#diff-25a5f460170324ee12ce61f62d09f6b8

avatar laoneo
laoneo - comment - 10 Aug 2017

Which is how it should be.

avatar laoneo laoneo - test_item - 10 Aug 2017 - Tested successfully
avatar laoneo
laoneo - comment - 10 Aug 2017

I have tested this item successfully on 9d77b88


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/17472.

avatar franz-wohlkoenig franz-wohlkoenig - change - 10 Aug 2017
Status Pending Ready to Commit
avatar franz-wohlkoenig
franz-wohlkoenig - comment - 10 Aug 2017

RTC after two successful tests.

avatar brianteeman
brianteeman - comment - 10 Aug 2017

Ok thanks

avatar infograf768 infograf768 - change - 10 Aug 2017
Title
Fix for #17449
[4.0] Fix for #17449
avatar infograf768 infograf768 - edited - 10 Aug 2017
avatar wilsonge wilsonge - change - 10 Aug 2017
Status Ready to Commit Fixed in Code Base
Closed_Date 0000-00-00 00:00:00 2017-08-10 21:09:35
Closed_By wilsonge
Labels Added: ? ?
avatar wilsonge wilsonge - close - 10 Aug 2017
avatar wilsonge wilsonge - merge - 10 Aug 2017
avatar wilsonge
wilsonge - comment - 10 Aug 2017

Thanks!

avatar zero-24
zero-24 - comment - 13 Aug 2017

Please notice: 3fc0ac2

Add a Comment

Login with GitHub to post a comment